Skip to content

fix(#678): load submission data in map #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
latin-panda wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −4
Open

fix(#678): load submission data in map #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fb4796
fix bug
latin-panda Feb 25, 2026
b59156f
changeset
latin-panda Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-walls-wave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@getodk/web-forms': patch
---

Fixes load submission data in maps
2 changes: 1 addition & 1 deletion packages/web-forms/src/components/common/map/AsyncMap.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ interface AsyncMapProps {
disabled: boolean;
singleFeatureType?: SingleFeatureType;
mode: Mode;
savedFeatureValue: string | undefined;
savedFeatureValue: SelectItem | string | undefined;
}

const props = defineProps<AsyncMapProps>();
Expand Down
2 changes: 1 addition & 1 deletion packages/web-forms/src/components/common/map/geojson-parsers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ const normalizeODKFeature = (odkFeature: SelectItem | string) => {
};

export const createFeatureCollectionAndProps = (
odkFeatures: readonly SelectItem[] | readonly string[] | undefined
odkFeatures: ReadonlyArray<SelectItem | string> | undefined
) => {
const orderedExtraPropsMap = new Map<string, Array<[key: string, value: string]>>();
const features: Feature[] = [];
Expand Down
4 changes: 2 additions & 2 deletions packages/web-forms/src/components/form-elements/select/Select1Control.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ const savedFeatureValue = computed(() => {
if (!props.question.appearances.map) {
return '';
}

const value = props.question.currentState.value?.[0];
const item = props.question.currentState.valueOptions.find((option) => option.value === value);
return item?.properties.find(([key = '']) => key === 'geometry')?.[1] ?? '';
return props.question.currentState.valueOptions.find((option) => option.value === value);
});

watchEffect(() => {
Expand Down