Skip to content

Conversation

@tysonwil
Copy link
Collaborator

@tysonwil tysonwil commented Sep 2, 2025

Summary

  • Adds the ability to return full RLP-encoded signed transactions for EVM chains, not just signatures
  • Extends the SignatureResult to include complete signed transaction data for EVM chains

Changes

  • Added signedTransaction field to SignatureResult struct for EVM support
  • Updated transaction signing flow to provide complete signed transaction when available
  • Maintains backward compatibility while providing enhanced EVM transaction support

Test Plan

  • Test signing EVM transactions and verify complete signed transaction is returned
  • Verify backward compatibility with existing signature flows
  • Test with various EVM chains to ensure proper transaction formatting

🤖 Generated with Claude Code

- Add signedTransaction optional field to SignatureResult
- Add transactionData computed property that returns signedTransaction for EVM or signature for others
- Extract signedTransaction from bridge response in signMessage and signTransaction methods
- Enables proper eth_sendRawTransaction support while maintaining backward compatibility

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@tysonwil tysonwil requested a review from jlm0 September 2, 2025 20:33
tysonwil and others added 2 commits September 2, 2025 15:33
- Removed fallback to 'signature' field
- Added proper error handling when signedTransaction is missing
- Updated to match bridge v2 API changes

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
@tysonwil tysonwil merged commit 1ca6ea8 into 2.0.0-alpha Sep 3, 2025
1 of 2 checks passed
@tysonwil tysonwil deleted the feat/evm-signed-transaction-support branch September 3, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants