Skip to content

feat: add support for returning complete signed EVM transactions #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tysonwil merged 3 commits into from
Sep 3, 2025
Merged

feat: add support for returning complete signed EVM transactions #33

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd02016
feat: add signedTransaction field to SignatureResult for EVM support
tysonwil Sep 2, 2025
7025cb2
fix: update Swift SDK to only expect signedTransaction field
tysonwil Sep 2, 2025
ffe7493
update for both fields
tysonwil Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions Sources/ParaSwift/Core/ParaManager+Signing.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,23 @@ import Foundation

/// Result of a signing operation
public struct SignatureResult {
/// The signature string
public let signature: String
/// The signed transaction data (for EVM, complete RLP-encoded transaction; for others, the signature)
public let signedTransaction: String
/// The wallet ID that signed
public let walletId: String
/// The wallet type (e.g., "evm", "solana", "cosmos")
public let type: String

public init(signature: String, walletId: String, type: String) {
self.signature = signature
public init(signedTransaction: String, walletId: String, type: String) {
self.signedTransaction = signedTransaction
self.walletId = walletId
self.type = type
}

/// Returns the transaction data for broadcasting.
public var transactionData: String {
return signedTransaction
}
}

/// Result of a transfer operation
Expand Down Expand Up @@ -97,12 +102,15 @@ public extension ParaManager {
// Parse the response from bridge
let dict = try decodeResult(result, expectedType: [String: Any].self, method: "formatAndSignMessage")

let signature = dict["signature"] as? String ?? ""
// Message signing returns signature field
guard let signature = dict["signature"] as? String else {
throw ParaError.bridgeError("Missing signature in response")
}
let returnedWalletId = dict["walletId"] as? String ?? walletId
let walletType = dict["type"] as? String ?? "unknown"

return SignatureResult(
signature: signature,
signedTransaction: signature, // Store signature in signedTransaction field for compatibility
walletId: returnedWalletId,
type: walletType
)
Expand Down Expand Up @@ -154,12 +162,20 @@ public extension ParaManager {
// Parse the response from bridge
let dict = try decodeResult(result, expectedType: [String: Any].self, method: "formatAndSignTransaction")

let signature = dict["signature"] as? String ?? ""
// Transaction signing returns signedTransaction (complete tx) or signature (when tx construction isn't possible)
let signedTransaction: String
if let tx = dict["signedTransaction"] as? String {
signedTransaction = tx // Complete transaction ready to broadcast
} else if let sig = dict["signature"] as? String {
signedTransaction = sig // Just signature (pre-serialized Solana, Cosmos fallback)
} else {
throw ParaError.bridgeError("Missing signedTransaction or signature in response")
}
let returnedWalletId = dict["walletId"] as? String ?? walletId
let walletType = dict["type"] as? String ?? "unknown"

return SignatureResult(
signature: signature,
signedTransaction: signedTransaction,
walletId: returnedWalletId,
type: walletType
)
Expand Down
Loading