Add series list view #575
Add series list view #575
Conversation
Add a series list view - as opposed to the default view which shows patches, this new view shows a list of all series. This is a much easier way to navigate and manage large repositories with 100+ patches (Some series alone contain more than 20-30 patches in a single series). This view will allow simple management of patch series. This version is MVP - and contains the basic view needed to navigate around.
|
As a user who missed the series view that presumably was in our ancient/horrible fork, this is great. Can you make the list show the number of patches in the series somewhere? |
Thanks, yes I'll work on it |
|
I've held of doing this because I wanted to add support for boolean Series states first, i.e. a series is either open/closed depending on the status of the state field of each associated Patch. I think this is still the priority, because without this the series page grows without end. This is also an issues with the I wonder if you'd be interested in working on that first? I suspect we can derive the value of an e.g. There are some other minor issues with the patch, which I'll leave comments for shortly, but I'd rather focus on closing the above first before we consider merging this. |
| </td> | ||
| </tr> | ||
| </table> | ||
| {% endif %} |
There was a problem hiding this comment.
This code is for bundles and doesn't do anything here. It can be removed.
| e.preventDefault(); | ||
| }); | ||
| }); | ||
| </script> |
There was a problem hiding this comment.
Are we doing anything with the checkboxes? Given we don't have any widgets for updating a series, I'd assume not? If so, do we need this?
| @@ -0,0 +1,154 @@ | |||
| {% load person %} | |||
There was a problem hiding this comment.
This doesn't need to be a partial. The only reason we have a patch-list partial is because we re-use that partial for both the patch list view and the bundle view (bundles are just lists of patches). You can combine this into series.html.
| @@ -36,6 +36,11 @@ | |||
| patch_views.patch_list, | |||
| name='patch-list', | |||
| ), | |||
| path( | |||
| 'project/<project_id>/series-list/', | |||
There was a problem hiding this comment.
We should align this with the URL structure of the rest of the URLs. For example, project/<project_id>/series/.
We'll also eventually need a series detail view (and a new-style mbox and patch view), but it's okay to tackle that separately.
| @@ -273,48 +275,65 @@ def generic_list( | |||
| else: | |||
| context['filters'].set_status(filterclass, setting) | |||
|
|
|||
| if patches is None: | |||
| patches = Patch.objects.filter(project=project) | |||
| if series_view: | |||
There was a problem hiding this comment.
Given we're not modifying anything here, I don't think there's any reason to re-use this function. It's already way too complicated for it's own good. Better to split this out into a new view function, IMO.
| ) | ||
|
|
||
| if request.user.is_authenticated: | ||
| context['bundles'] = request.user.bundles.all() |
There was a problem hiding this comment.
This isn't used anywhere so it doesn't need to be here.
Add a series list view - as opposed to the default view which shows patches, this new view shows a list of all series. This is a much easier way to navigate and manage large repositories with 100+ patches (Some series alone contain more than 20-30 patches in a single series). This view will allow simple management of patch series. This version is MVP - and contains the basic view needed to navigate around.
Closes #509