Skip to content

Conversation

@carolynvs
Copy link
Member

What does this change

Not sure if we'll actually do this. I updated SourceMapList to ArrayMap (naming is hard!) and saw just how much would be impacted by changing the data structure from a slice to a map.

What issue does it fix

Nothing, Aaron nerd sniped me 😅

Notes for the reviewer

N/A

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs force-pushed the generic-sourcemaplist branch from 1ab0221 to 0af33db Compare April 26, 2023 19:40
@carolynvs carolynvs mentioned this pull request Apr 27, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant