Remove go.mod replacements #3291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgannon991
force-pushed
the
chore/remove-replacements
branch
2 times, most recently
from
ade6a67 to
fb5dbb5
Compare
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
dgannon991
force-pushed
the
chore/remove-replacements
branch
from
244742a to
202cdcc
Compare
dgannon991
requested review from
schristoff,
sgettys,
bdegeeter,
troy0820 and
kichristensen
as code owners
|
Hi Guys, managed to get one replace out with no changes, and the custom method in viper I just moved into our codebase so we could point to the latest :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Quite a few of the replacements in our go mod are from several years ago, pointing to forks which are sometimes several hundred commits out of date. I'm going to work through and re-evaluate if they're still needed, or if we can move back to the main repo.
Notes for the reviewer
Still very much a WIP.
Checklist