Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 12, 2025

What type of PR is this?

  • Bug Fix

Description

The listener address is hardcoded to IPv4-only (0.0.0.0) which breaks in an IPv6-only host. gunicorn supports the [::] host as a dualstack wildcard, so that's what I'm changing here.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Built the docker image locally and started it

@ghost
Copy link
Author

ghost commented Dec 12, 2025

Reopening PR #7589

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@ghost
Copy link
Author

ghost commented Dec 12, 2025

In a dual-stack environment, both 0.0.0.0 and [::] work for both v4 and v6, but in a v6-only system, only [::] works properly.

@eradman
Copy link
Collaborator

eradman commented Dec 12, 2025

In a dual-stack environment, both 0.0.0.0 and [::] work for both v4 and v6, but in a v6-only system, only [::] works properly.

Do you mean that IPv4 is disabled, or that routing for IPv4 addresses are not assigned?

@ghost
Copy link
Author

ghost commented Dec 12, 2025

Do you mean that IPv4 is disabled, or that routing for IPv4 addresses are not assigned?

IPv4 is disabled at the host level

Copy link
Collaborator

@eradman eradman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does solve the problem when running single-stack IPv6

$ host redash.default.svc.mykube.lan
redash.default.svc.mykube.lan has IPv6 address fd00:f4:2::c

Tested on kubernetes using

---
apiVersion: v1
kind: Service
metadata:
  name: redash
spec:
  clusterIP: None
  ports:
  - port: 5000
    targetPort: 5000
  selector:
    app: redash
  ipFamilyPolicy: SingleStack
  ipFamilies:
  - IPv6

Also confirmed that this is still compatible with IPv4.
Thank you @aldo-airtm!

@eradman eradman enabled auto-merge (squash) December 24, 2025 19:44
@eradman
Copy link
Collaborator

eradman commented Dec 24, 2025

@aldo-airtm please try rebasing this change and pushing agin

auto-merge was automatically disabled January 29, 2026 10:33

Head branch was pushed to by a user without write access

@aldofunes
Copy link

@aldo-airtm please try rebasing this change and pushing agin

@eradman Sorry it took a while, it's now rebased

@eradman eradman merged commit d2a7d87 into getredash:master Jan 29, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants