refactor: a pytest-specific action #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWoodard
reviewed
May 10, 2024
bukzor
force-pushed
the
bukzor/pytest-specific-action
branch
from
2fd1b08
to
34d077b
Compare
bukzor
force-pushed
the
bukzor/pytest-specific-action
branch
from
34d077b
to
f9c846f
Compare
bukzor
force-pushed
the
bukzor/pytest-specific-action
branch
from
6fa6df9
to
232e268
Compare
bukzor
force-pushed
the
bukzor/pytest-specific-action
branch
2 times, most recently
from
ad2f539
to
84e0bf2
Compare
IanWoodard
approved these changes
May 10, 2024
| run: | ||
| shell: bash -euxo pipefail {0} | ||
| env: | ||
| PS4: "\e[36m$\e[m " |
| uses: ./pytest | ||
| with: | ||
| _deploy_environ: dev | ||
| _gcp_project: di-dev-mtr--buck-5 |
There was a problem hiding this comment.
Should we have a dedicated gcp project for self-test? Just so we don't accidentally clobber it.
| workload_identity_provider: ${{ secrets.SENTRY_GCP_DEV_WORKLOAD_IDENTITY_POOL }} | ||
| service_account_email: ${{ secrets.SUDO_GCP_SERVICE_ACCOUNT }} | ||
| _deploy_environ: dev | ||
| _gcp_project: di-dev-mtr--buck-5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.