Name parameterize business hour functions #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
=======================================
Coverage 86.19% 86.19%
=======================================
Files 116 116
Lines 3231 3231
Branches 656 656
=======================================
Hits 2785 2785
Misses 432 432
Partials 14 14 ☔ View full report in Codecov by Sentry. |
azaslavsky
approved these changes
Dec 29, 2023
| return calculateTimeToRespondBy( | ||
| MAX_TRIAGE_DAYS, | ||
| target_name.slice(PRODUCT_AREA_LABEL_PREFIX.length), | ||
| return calculateTimeToRespondBy({ |
There was a problem hiding this comment.
Surprising that this line is not hit by tests? Maybe the instrumentation is being weird?
| productArea, | ||
| repo, | ||
| org, | ||
| testTimestamp, |
There was a problem hiding this comment.
nit: Is this an argument that we only pass in for testing? I wonder if there's another way to do this, a la pythong's freezgun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #737