This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Print the recovered value before dumping stack trace #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the RecoveryHandler would catch panics and log them to Sentry, but not log any information about the error to stderr, making it more difficult to debug than an ordinary panic. Instead, print a pseudo-panic header to stderr before printing the stack trace. Stderr printed by the RecoveryHandler on a panic now looks like this: ``` panic: unknown property Region goroutine 55 [running]: runtime/debug.Stack(0x19, 0x0, 0x0) /Users/kevin/go/src/runtime/debug/stack.go:24 +0x79 runtime/debug.PrintStack() /Users/kevin/go/src/runtime/debug/stack.go:16 +0x22 github.com/saintpete/logrole/vendor/github.com/getsentry/raven-go.RecoveryHandler.func1.1(0xc420746e10, 0x791be0, 0xc4205d1e90) /Users/kevin/code/go/src/github.com/saintpete/logrole/vendor/github.com/getsentry/raven-go/http.go:100 +0x106 panic(0x46d760, 0xc4204d0210) /Users/kevin/go/src/runtime/panic.go:458 +0x243 text/template.errRecover(0xc4207a5248) /Users/kevin/go/src/text/template/exec.go:146 +0x18e ``` Fixes getsentry#109.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the RecoveryHandler would catch panics and log them to Sentry, but
not log any information about the error to stderr, making it more difficult to
debug than an ordinary panic. Instead, print a pseudo-panic header to stderr
before printing the stack trace.
Stderr printed by the RecoveryHandler on a panic now looks like this:
Fixes #109.