Carthage compatibility #47
Conversation
|
The first commit of this PR seems to be covered by #44, which is merged now. Can you merge with master to update this PR so it can be merged without conflicts? Thanks for the PR by the way :) |
I'll do it. Probably over the week end. |
Conflicts: Raven.xcodeproj/project.pbxproj Raven/Raven.h
|
Merge done. |
|
I think, dropping a static library target for a framework is too radical. So, I have preserved a static library target during the merge. Also, I've added a static framework target. |
|
Great. There is one issue though. After switching to XCTest the test suite will no longer run. |
Not sure what you mean. I have tested XCTest targets and they worked. What else do you want me to fix? Are there any scripts I've missed? |
|
In your PR it has been added a new Raven group, a content-less RavenClientTests group, a RavenTests group with an empty test, and an extra test bundle in the test navigator. It would be awesome if you could clean away the unused groups and the extra test-bundle in the test navigator. |
|
@timorzadir could you please post some screenshots to avoid the misunderstanding again? |
Cold you provide more detailed steps to reproduce? Before submitting this patch I have tested both the static lib based tests and the framework based tests. Both of them worked for me. So, I cannot reproduce the issue. Note : two test bundles cannot be executed within the same scheme due to a bug of Xcode. Isn't it a reason why you can run only one bundle? |
Added a static library and iOS8 framework targets.
The library is now compatible with Carthage package manager.
Note : you should to make a fork so that carthage versioning would recognise these changes