fix broken span db system query

getsentry · Oct 9, 2024 · 69dc769 · 69dc769
1 parent 21db425
commit 69dc769
Show file tree

Hide file tree

Showing 3 changed files with 117 additions and 1 deletion.
diff --git a/relay-dynamic-config/src/defaults.rs b/relay-dynamic-config/src/defaults.rs
@@ -117,7 +117,7 @@ pub fn hardcoded_span_metrics() -> Vec<(GroupKey, Vec<MetricSpec>, Vec<TagMappin
     let is_db = RuleCondition::eq("span.sentry_tags.category", "db")
         & !RuleCondition::glob("span.op", DISABLED_DATABASES)
         // MongoDB queries are only allowed when `span.system` is set to `mongodb`.
-        & (RuleCondition::eq("span.system", "mongodb")
+        & (RuleCondition::eq("span.data.db\\.system", "mongodb")
             | !RuleCondition::glob("span.description", MONGODB_QUERIES));
     let is_resource = RuleCondition::glob("span.op", RESOURCE_SPAN_OPS);
 

diff --git a/...snapshots/relay_server__metrics_extraction__event__tests__both_feature_flags_enabled.snap b/...snapshots/relay_server__metrics_extraction__event__tests__both_feature_flags_enabled.snap
@@ -3682,8 +3682,12 @@ expression: metrics
         ),
         tags: {
             "environment": "fake_environment",
+            "span.action": "COUNT",
+            "span.category": "db",
             "span.op": "db.sql.query",
+            "span.system": "mongodb",
             "transaction": "gEt /api/:version/users/",
+            "transaction.method": "POST",
             "transaction.op": "myop",
         },
         metadata: BucketMetadata {
@@ -3694,6 +3698,32 @@ expression: metrics
             extracted_from_indexed: false,
         },
     },
+    Bucket {
+        timestamp: UnixTimestamp(1597976302),
+        width: 0,
+        name: MetricName(
+            "d:spans/exclusive_time_light@millisecond",
+        ),
+        value: Distribution(
+            [
+                2000.0,
+            ],
+        ),
+        tags: {
+            "environment": "fake_environment",
+            "span.action": "COUNT",
+            "span.category": "db",
+            "span.op": "db.sql.query",
+            "span.system": "mongodb",
+        },
+        metadata: BucketMetadata {
+            merges: 1,
+            received_at: Some(
+                UnixTimestamp(0),
+            ),
+            extracted_from_indexed: false,
+        },
+    },
     Bucket {
         timestamp: UnixTimestamp(1597976302),
         width: 0,
@@ -3707,8 +3737,12 @@ expression: metrics
         ),
         tags: {
             "environment": "fake_environment",
+            "span.action": "COUNT",
+            "span.category": "db",
             "span.op": "db.sql.query",
+            "span.system": "mongodb",
             "transaction": "gEt /api/:version/users/",
+            "transaction.method": "POST",
             "transaction.op": "myop",
         },
         metadata: BucketMetadata {
@@ -3719,6 +3753,32 @@ expression: metrics
             extracted_from_indexed: false,
         },
     },
+    Bucket {
+        timestamp: UnixTimestamp(1597976302),
+        width: 0,
+        name: MetricName(
+            "d:spans/duration_light@millisecond",
+        ),
+        value: Distribution(
+            [
+                2000.0,
+            ],
+        ),
+        tags: {
+            "environment": "fake_environment",
+            "span.action": "COUNT",
+            "span.category": "db",
+            "span.op": "db.sql.query",
+            "span.system": "mongodb",
+        },
+        metadata: BucketMetadata {
+            merges: 1,
+            received_at: Some(
+                UnixTimestamp(0),
+            ),
+            extracted_from_indexed: false,
+        },
+    },
     Bucket {
         timestamp: UnixTimestamp(1597976302),
         width: 0,

diff --git a/...ics_extraction/snapshots/relay_server__metrics_extraction__event__tests__only_common.snap b/...ics_extraction/snapshots/relay_server__metrics_extraction__event__tests__only_common.snap
@@ -3388,8 +3388,11 @@ expression: metrics
         ),
         tags: {
             "environment": "fake_environment",
+            "span.action": "COUNT",
+            "span.category": "db",
             "span.op": "db.sql.query",
             "transaction": "gEt /api/:version/users/",
+            "transaction.method": "POST",
             "transaction.op": "myop",
         },
         metadata: BucketMetadata {
@@ -3400,6 +3403,31 @@ expression: metrics
             extracted_from_indexed: false,
         },
     },
+    Bucket {
+        timestamp: UnixTimestamp(1597976302),
+        width: 0,
+        name: MetricName(
+            "d:spans/exclusive_time_light@millisecond",
+        ),
+        value: Distribution(
+            [
+                2000.0,
+            ],
+        ),
+        tags: {
+            "environment": "fake_environment",
+            "span.action": "COUNT",
+            "span.category": "db",
+            "span.op": "db.sql.query",
+        },
+        metadata: BucketMetadata {
+            merges: 1,
+            received_at: Some(
+                UnixTimestamp(0),
+            ),
+            extracted_from_indexed: false,
+        },
+    },
     Bucket {
         timestamp: UnixTimestamp(1597976302),
         width: 0,
@@ -3413,8 +3441,11 @@ expression: metrics
         ),
         tags: {
             "environment": "fake_environment",
+            "span.action": "COUNT",
+            "span.category": "db",
             "span.op": "db.sql.query",
             "transaction": "gEt /api/:version/users/",
+            "transaction.method": "POST",
             "transaction.op": "myop",
         },
         metadata: BucketMetadata {
@@ -3425,6 +3456,31 @@ expression: metrics
             extracted_from_indexed: false,
         },
     },
+    Bucket {
+        timestamp: UnixTimestamp(1597976302),
+        width: 0,
+        name: MetricName(
+            "d:spans/duration_light@millisecond",
+        ),
+        value: Distribution(
+            [
+                2000.0,
+            ],
+        ),
+        tags: {
+            "environment": "fake_environment",
+            "span.action": "COUNT",
+            "span.category": "db",
+            "span.op": "db.sql.query",
+        },
+        metadata: BucketMetadata {
+            merges: 1,
+            received_at: Some(
+                UnixTimestamp(0),
+            ),
+            extracted_from_indexed: false,
+        },
+    },
     Bucket {
         timestamp: UnixTimestamp(1597976302),
         width: 0,