fix(tests): Fix flaky test_readiness_not_enough_memory_bytes
#4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
approved these changes
Oct 7, 2024
|
As discussed offline, let's first try to re-run in CI the new timeouts to have a higher degree of confidence that flakiness is reduced. |
jjbayer
changed the title
test_readiness_not_enough_memory_bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unflake
test_readiness_not_enough_memoryandtest_readiness_not_enough_bytes. The relay errors expected by these tests did not always occur in order, and not always within 1 second.I confirmed by brute force that these tests no longer fail, even with 100 repetitions: https://github.com/getsentry/relay/actions/runs/11235435151/job/31233375132?pr=4115#step:8:735
Fixes #4090.
#skip-changelog