Update SentryReplayApi.m

getsentry · Oct 17, 2024 · d705969 · d705969
1 parent b695b61
commit d705969
Showing 1 changed file with 16 additions and 11 deletions.
diff --git a/Sources/Sentry/SentryReplayApi.m b/Sources/Sentry/SentryReplayApi.m
@@ -39,20 +39,25 @@ - (void)resume
 
 - (void)start
 {
-    SentrySessionReplayIntegration *replayIntegration
+    // Start could be misused and called multiple times, causing it to
+    // be initialized more than once before being installed.
+    // Synchronizing it will prevent this problem.
+    @synchronized (self) {
+        SentrySessionReplayIntegration *replayIntegration
         = (SentrySessionReplayIntegration *)[SentrySDK.currentHub
-            getInstalledIntegration:SentrySessionReplayIntegration.class];
-
-    if (replayIntegration == nil) {
-        SentryOptions *currentOptions = SentrySDK.currentHub.client.options;
-        replayIntegration =
+                                             getInstalledIntegration:SentrySessionReplayIntegration.class];
+        
+        if (replayIntegration == nil) {
+            SentryOptions *currentOptions = SentrySDK.currentHub.client.options;
+            replayIntegration =
             [[SentrySessionReplayIntegration alloc] initForManualUse:currentOptions];
-
-        [SentrySDK.currentHub addInstalledIntegration:replayIntegration
-                                                 name:NSStringFromClass(SentrySessionReplay.class)];
+
+            [SentrySDK.currentHub addInstalledIntegration:replayIntegration
+                                                     name:NSStringFromClass(SentrySessionReplay.class)];
+        }
+
+        [replayIntegration start];
     }
-
-    [replayIntegration start];
 }
 
 - (void)stop