Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add frames delay to span data #3496

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Conversation

philipphofmann
Copy link
Member

📜 Description

Also fix a couple of edge cases when calculating the frames delay when an ongoing delayed frame is not yet recorded.

💡 Motivation and Context

Fixes GH-3481

💚 How did you test it?

Unit tests and with the simulator

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Update the docs once we show the feature in mobile starfish.

Also fix a couple of edge cases when calculating the frames delay when
an ongoing delayed frame is not yet recorded.
Copy link

github-actions bot commented Dec 14, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8409dee

Copy link

github-actions bot commented Dec 14, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.75 ms 1254.57 ms 16.82 ms
Size 21.58 KiB 418.35 KiB 396.76 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b064665 1230.04 ms 1254.08 ms 24.04 ms
ddc9b9a 1210.00 ms 1234.18 ms 24.18 ms
50bbebb 1234.76 ms 1246.66 ms 11.90 ms
2154ae1 1216.06 ms 1244.78 ms 28.72 ms
e7b566f 1199.57 ms 1218.76 ms 19.19 ms
fb53d97 1226.08 ms 1245.12 ms 19.04 ms
e8b11f8 1233.66 ms 1249.74 ms 16.08 ms
881a955 1230.69 ms 1244.12 ms 13.43 ms
3437454 1254.04 ms 1259.50 ms 5.46 ms
5ab598f 1213.90 ms 1240.45 ms 26.55 ms

App size

Revision Plain With Sentry Diff
b064665 22.85 KiB 413.42 KiB 390.57 KiB
ddc9b9a 20.76 KiB 420.40 KiB 399.64 KiB
50bbebb 21.58 KiB 414.96 KiB 393.38 KiB
2154ae1 20.76 KiB 427.83 KiB 407.06 KiB
e7b566f 22.85 KiB 414.80 KiB 391.95 KiB
fb53d97 20.76 KiB 425.81 KiB 405.04 KiB
e8b11f8 22.85 KiB 411.92 KiB 389.07 KiB
881a955 22.85 KiB 407.63 KiB 384.78 KiB
3437454 22.85 KiB 408.87 KiB 386.02 KiB
5ab598f 22.84 KiB 403.17 KiB 380.33 KiB

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #3496 (8409dee) into main (de033da) will increase coverage by 0.014%.
The diff coverage is 100.000%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3496       +/-   ##
=============================================
+ Coverage   89.163%   89.178%   +0.014%     
=============================================
  Files          528       528               
  Lines        57224     57441      +217     
  Branches     20260     20579      +319     
=============================================
+ Hits         51023     51225      +202     
- Misses        5286      5297       +11     
- Partials       915       919        +4     
Files Coverage Δ
Sources/Sentry/SentryDelayedFramesTracker.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryFramesTracker.m 100.000% <100.000%> (ø)
Sources/Sentry/SentrySpan.m 98.453% <100.000%> (+0.057%) ⬆️
...ance/FramesTracking/SentryFramesTrackerTests.swift 99.082% <100.000%> (+0.051%) ⬆️
...ests/SentryTests/Transaction/SentrySpanTests.swift 99.389% <100.000%> (-0.010%) ⬇️

... and 66 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de033da...8409dee. Read the comment docs.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit f0ce81c into main Dec 18, 2023
70 checks passed
@philipphofmann philipphofmann deleted the feat/frames-delay-to-spans branch December 18, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add frames delay for transactions and spans
2 participants