Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Support for non-fully-blocking app hangs #4286

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Aug 16, 2024

📜 Description

Add the logic for non-fully-blocking app hangs when the frame delay exceeds 99%.

This PR is based on #4285.

#skip-changelog

💡 Motivation and Context

This is required for GH-3492.

💚 How did you test it?

Running on a real device and unit tests.

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Add the logic for non-fully-blocking app hangs when the frame delay
exceeds 99%. This is required for GH-3492.
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.679%. Comparing base (5ed60fb) to head (0b4381d).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4286       +/-   ##
=============================================
+ Coverage   91.640%   91.679%   +0.039%     
=============================================
  Files          617       617               
  Lines        50197     50216       +19     
  Branches     18130     18134        +4     
=============================================
+ Hits         46001     46038       +37     
+ Misses        4103      4086       -17     
+ Partials        93        92        -1     
Files Coverage Δ
Sources/Sentry/SentryANRTrackerV2.m 99.115% <100.000%> (+0.049%) ⬆️
Sources/Sentry/SentryANRTrackingIntegrationV2.m 97.368% <ø> (ø)
...sts/Integrations/ANR/SentryANRTrackerV2Tests.swift 100.000% <100.000%> (ø)
...ations/ANR/SentryANRTrackingIntegrationTests.swift 95.620% <100.000%> (ø)
...ions/ANR/SentryANRTrackingIntegrationV2Tests.swift 95.620% <100.000%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ed60fb...0b4381d. Read the comment docs.

Base automatically changed from ref/convert-anrv2delegate-to-swift to main August 16, 2024 08:02
Copy link

github-actions bot commented Aug 16, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.06 ms 1253.22 ms 18.15 ms
Size 21.58 KiB 707.28 KiB 685.70 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e84bc3f 1196.62 ms 1218.86 ms 22.24 ms
3033115 1260.10 ms 1263.58 ms 3.48 ms
e072ad1 1221.35 ms 1237.48 ms 16.13 ms
fc163f5 1219.18 ms 1242.74 ms 23.56 ms
596ccc1 1221.57 ms 1236.82 ms 15.25 ms
ecd9ecd 1215.77 ms 1238.70 ms 22.93 ms
fcde045 1197.91 ms 1224.80 ms 26.89 ms
9ccd421 1196.90 ms 1209.63 ms 12.73 ms
f8833c4 1230.00 ms 1245.27 ms 15.27 ms
3b4110a 1228.90 ms 1247.65 ms 18.76 ms

App size

Revision Plain With Sentry Diff
e84bc3f 20.76 KiB 434.72 KiB 413.96 KiB
3033115 22.85 KiB 405.84 KiB 382.99 KiB
e072ad1 21.58 KiB 625.82 KiB 604.24 KiB
fc163f5 20.76 KiB 436.29 KiB 415.53 KiB
596ccc1 22.84 KiB 401.44 KiB 378.60 KiB
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB
fcde045 20.76 KiB 435.26 KiB 414.50 KiB
9ccd421 21.58 KiB 418.82 KiB 397.24 KiB
f8833c4 21.58 KiB 422.66 KiB 401.08 KiB
3b4110a 21.58 KiB 625.82 KiB 604.24 KiB

Previous results on branch: chore/non-fully-blocking-app-hangs

Startup times

Revision Plain With Sentry Diff
2721ca2 1236.19 ms 1248.02 ms 11.83 ms

App size

Revision Plain With Sentry Diff
2721ca2 21.58 KiB 706.86 KiB 685.28 KiB

@philipphofmann philipphofmann merged commit fff4a70 into main Aug 16, 2024
65 checks passed
@philipphofmann philipphofmann deleted the chore/non-fully-blocking-app-hangs branch August 16, 2024 08:54
@philipphofmann philipphofmann self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants