Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(user feedback): display a button in a window that presents a vc #4364

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
+662 −139

fix deprecation/rename

1bc5a95
Select commit
Loading
Failed to load commit list.
Open

feat(user feedback): display a button in a window that presents a vc #4364

fix deprecation/rename
1bc5a95
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 18, 2024 in 0s

91.424% (+0.105%) compared to 149877e

View this Pull Request on Codecov

91.424% (+0.105%) compared to 149877e

Details

Codecov Report

Attention: Patch coverage is 8.62534% with 339 lines in your changes missing coverage. Please review.

Project coverage is 91.424%. Comparing base (149877e) to head (1bc5a95).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...rFeedback/SentryUserFeedbackWidgetButtonView.swift 0.000% 147 Missing ⚠️
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% 65 Missing ⚠️
...tryUserFeedbackWidgetButtonMegaphoneIconView.swift 0.000% 50 Missing ⚠️
...s/UserFeedback/SentryUserFeedbackIntegration.swift 0.000% 34 Missing ⚠️
...onfiguration/SentryUserFeedbackConfiguration.swift 0.000% 18 Missing ⚠️
...uration/SentryUserFeedbackThemeConfiguration.swift 0.000% 6 Missing ⚠️
.../UserFeedback/SentryUserFeedbackIntegrationShell.m 0.000% 5 Missing ⚠️
Sources/Sentry/NSLocale+Sentry.m 0.000% 4 Missing ⚠️
Sources/Sentry/SentryOptions.m 85.185% 4 Missing ⚠️
...ration/SentryUserFeedbackWidgetConfiguration.swift 0.000% 4 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4364       +/-   ##
=============================================
+ Coverage   91.318%   91.424%   +0.105%     
=============================================
  Files          609       614        +5     
  Lines        49855     68488    +18633     
  Branches     17932     24578     +6646     
=============================================
+ Hits         45527     62615    +17088     
- Misses        4236      5781     +1545     
  Partials        92        92
Files with missing lines Coverage Δ
...guration/SentryUserFeedbackFormConfiguration.swift 0.000% <ø> (ø)
Sources/Sentry/SentrySDK.m 87.654% <81.818%> (-0.744%) ⬇️
Sources/Sentry/NSLocale+Sentry.m 71.428% <0.000%> (-28.572%) ⬇️
Sources/Sentry/SentryOptions.m 98.691% <85.185%> (-0.561%) ⬇️
...ration/SentryUserFeedbackWidgetConfiguration.swift 0.000% <0.000%> (ø)
.../UserFeedback/SentryUserFeedbackIntegrationShell.m 0.000% <0.000%> (ø)
...uration/SentryUserFeedbackThemeConfiguration.swift 0.000% <0.000%> (ø)
...onfiguration/SentryUserFeedbackConfiguration.swift 0.000% <0.000%> (ø)
...s/UserFeedback/SentryUserFeedbackIntegration.swift 0.000% <0.000%> (ø)
...tryUserFeedbackWidgetButtonMegaphoneIconView.swift 0.000% <0.000%> (ø)
... and 2 more

... and 571 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149877e...1bc5a95. Read the comment docs.

View more details on Codecov