Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename session replay redact options and APIs to mask #4373

Merged
merged 14 commits into from
Oct 4, 2024

Merge branch 'main' into feat/SwiftSR-Unmask

fa26b21
Select commit
Loading
Failed to load commit list.
Merged

Rename session replay redact options and APIs to mask #4373

Merge branch 'main' into feat/SwiftSR-Unmask
fa26b21
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 4, 2024 in 0s

91.461% (+0.026%) compared to c7aec2a

View this Pull Request on Codecov

91.461% (+0.026%) compared to c7aec2a

Details

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.461%. Comparing base (c7aec2a) to head (fa26b21).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/SentrySwiftUI/SentryReplayView.swift 50.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4373       +/-   ##
=============================================
+ Coverage   91.434%   91.461%   +0.026%     
=============================================
  Files          628       629        +1     
  Lines        50541     50630       +89     
  Branches     18249     18354      +105     
=============================================
+ Hits         46212     46307       +95     
+ Misses        4238      4232        -6     
  Partials        91        91               
Files with missing lines Coverage Δ
Sources/Sentry/SentryReplayApi.m 25.000% <100.000%> (ø)
Sources/Swift/Extensions/UIViewExtensions.swift 100.000% <100.000%> (ø)
...tegrations/SessionReplay/SentryReplayOptions.swift 93.103% <100.000%> (ø)
Sources/Swift/Tools/UIRedactBuilder.swift 96.491% <100.000%> (ø)
...onReplay/SentrySessionReplayIntegrationTests.swift 98.636% <100.000%> (ø)
...entryTests/SwiftUI/SentryRedactModifierTests.swift 100.000% <100.000%> (ø)
Tests/SentryTests/UIRedactBuilderTests.swift 100.000% <100.000%> (ø)
Sources/SentrySwiftUI/SentryReplayView.swift 20.000% <50.000%> (ø)

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7aec2a...fa26b21. Read the comment docs.