Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AppHangsV2 #4379

Merged
merged 7 commits into from
Oct 8, 2024
Merged

feat: AppHangsV2 #4379

merged 7 commits into from
Oct 8, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Sep 30, 2024

📜 Description

Expose the AppHangsV2 algorithm with the options
enableAppHangTrackingV2 and
enableReportNonFullyBlockingAppHangs.

Docs PR: getsentry/sentry-docs#11458.

💡 Motivation and Context

Fixes GH-3492

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Expose the AppHangsV2 algorithm with the options
enableAppHangTrackingV2 and
enableReportNonFullyBlockingAppHangs.

Fixes GH-3492
Copy link

github-actions bot commented Sep 30, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 893309a

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.448%. Comparing base (2f5e5f7) to head (893309a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ations/ANR/SentryANRTrackingIntegrationTests.swift 88.888% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4379       +/-   ##
=============================================
+ Coverage   91.443%   91.448%   +0.004%     
=============================================
  Files          629       629               
  Lines        50630     50655       +25     
  Branches     18344     18314       -30     
=============================================
+ Hits         46298     46323       +25     
  Misses        4238      4238               
  Partials        94        94               
Files with missing lines Coverage Δ
Sources/Sentry/SentryANRTrackingIntegration.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryBaseIntegration.m 96.969% <100.000%> (+5.541%) ⬆️
Sources/Sentry/SentryDependencyContainer.m 96.250% <100.000%> (+7.009%) ⬆️
Sources/Sentry/SentryEvent.m 98.924% <100.000%> (+0.011%) ⬆️
Sources/Sentry/SentryOptions.m 99.270% <100.000%> (+0.005%) ⬆️
...try/SentryWatchdogTerminationTrackingIntegration.m 93.750% <100.000%> (+0.132%) ⬆️
Sources/Swift/Integrations/ANR/SentryANRType.swift 100.000% <100.000%> (ø)
...yTests/Helper/SentryDependencyContainerTests.swift 100.000% <100.000%> (ø)
Tests/SentryTests/SentryOptionsTest.m 97.905% <100.000%> (+0.002%) ⬆️
...ations/ANR/SentryANRTrackingIntegrationTests.swift 93.236% <88.888%> (-2.384%) ⬇️

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5e5f7...893309a. Read the comment docs.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but CI is not happy

@philipphofmann
Copy link
Member Author

@brustolin, CI is happy now, except for benchmarks, but that's Saucelabs. Please have another look.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Oct 7, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.35 ms 1256.90 ms 25.55 ms
Size 21.58 KiB 729.89 KiB 708.31 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1bf8571 1250.96 ms 1255.36 ms 4.40 ms
2ccbd03 1225.13 ms 1247.51 ms 22.39 ms
d011484 1220.86 ms 1237.18 ms 16.33 ms
6001822 1220.82 ms 1245.02 ms 24.20 ms
3723833 1205.22 ms 1216.94 ms 11.71 ms
ff09c7e 1240.94 ms 1262.66 ms 21.72 ms
b9d59f7 1250.71 ms 1257.78 ms 7.06 ms
94d8eb3 1234.02 ms 1249.63 ms 15.60 ms
e773cad 1219.86 ms 1238.26 ms 18.40 ms
90d17d3 1261.18 ms 1278.18 ms 17.00 ms

App size

Revision Plain With Sentry Diff
1bf8571 20.76 KiB 437.12 KiB 416.36 KiB
2ccbd03 21.58 KiB 546.20 KiB 524.62 KiB
d011484 21.58 KiB 616.14 KiB 594.56 KiB
6001822 22.85 KiB 410.98 KiB 388.13 KiB
3723833 21.58 KiB 424.34 KiB 402.76 KiB
ff09c7e 20.76 KiB 427.76 KiB 407.00 KiB
b9d59f7 22.85 KiB 405.77 KiB 382.93 KiB
94d8eb3 21.58 KiB 417.86 KiB 396.28 KiB
e773cad 21.58 KiB 681.75 KiB 660.17 KiB
90d17d3 20.76 KiB 432.17 KiB 411.41 KiB

@philipphofmann philipphofmann merged commit 187edbf into main Oct 8, 2024
63 of 65 checks passed
@philipphofmann philipphofmann deleted the feat/app-hang-v2-option branch October 8, 2024 06:15
philipphofmann added a commit that referenced this pull request Oct 18, 2024
#4405 and #4379 are part of 8.39.0 and not 8.38.0.
philipphofmann added a commit that referenced this pull request Oct 18, 2024
#4405 and #4379 are part of 8.39.0 and not 8.38.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the option to ignore non fully blocking app hangs
2 participants