Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Finish TTID when viewWillAppear is skipped #4417

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: Finish TTID when viewWillAppear is skipped #4417

merged 1 commit into from
Oct 11, 2024

Commits on Oct 9, 2024

  1. fix: Finish TTID when viewWillAppear is skipped 

    According to the Apple docs, viewWillAppear should be called before the
UIViewController is added to the view hierarchy. There are some edge
cases, though, when this doesn't happen, and we saw customers'
transactions also proofing this. Therefore, we must also report the
initial display here, as the customers' transactions had spans for
viewWillLayoutSubViews.

Fixes GH-4383
    @philipphofmann
    philipphofmann committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    518a25b View commit details
    Browse the repository at this point in the history