Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove unused reportUserException #4438

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

philipphofmann
Copy link
Member

The sentrycrash_reportUserException only exists in the header and isn't used anywhere. We can remove it.

#skip-changelog

The sentrycrash_reportUserException only exists in the header and isn't
used anywhere. We can remove it.
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.347%. Comparing base (f273312) to head (225905e).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4438       +/-   ##
=============================================
+ Coverage   91.333%   91.347%   +0.014%     
=============================================
  Files          610       610               
  Lines        49927     49927               
  Branches     18033     18016       -17     
=============================================
+ Hits         45600     45607        +7     
+ Misses        4235      4228        -7     
  Partials        92        92               

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f273312...225905e. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1205.24 ms 1233.45 ms 28.21 ms
Size 21.58 KiB 707.35 KiB 685.77 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b2c9166 1246.86 ms 1255.28 ms 8.42 ms
02e1163 1199.86 ms 1211.78 ms 11.92 ms
ee8b48f 1196.80 ms 1213.48 ms 16.68 ms
533c68f 1236.54 ms 1256.68 ms 20.14 ms
10ee2ce 1250.90 ms 1258.57 ms 7.67 ms
1f9387b 1229.00 ms 1256.49 ms 27.49 ms
bef2003 1248.18 ms 1258.86 ms 10.68 ms
6943de0 1237.67 ms 1247.12 ms 9.45 ms
326b7eb 1204.76 ms 1234.96 ms 30.20 ms
50b058e 1212.29 ms 1231.16 ms 18.88 ms

App size

Revision Plain With Sentry Diff
b2c9166 21.58 KiB 630.26 KiB 608.68 KiB
02e1163 21.58 KiB 418.82 KiB 397.24 KiB
ee8b48f 21.58 KiB 418.70 KiB 397.11 KiB
533c68f 21.58 KiB 630.28 KiB 608.70 KiB
10ee2ce 20.76 KiB 427.77 KiB 407.00 KiB
1f9387b 21.58 KiB 654.26 KiB 632.68 KiB
bef2003 22.85 KiB 407.73 KiB 384.88 KiB
6943de0 20.76 KiB 393.33 KiB 372.57 KiB
326b7eb 20.76 KiB 432.31 KiB 411.55 KiB
50b058e 21.58 KiB 714.30 KiB 692.72 KiB

@philipphofmann philipphofmann merged commit 36d4147 into main Oct 15, 2024
65 checks passed
@philipphofmann philipphofmann deleted the ref/remove-unused-report-user-exception branch October 15, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants