Fix: Thread running at User-initiated quality-of-service for Session replay

[brustolin]

📜 Description

AVFoundation video maker runs on a lower QoS than user-initiated processes, and the thread sanitizer complains about waiting for it on a higher-level thread. We are changing the QoS of our call to create video.

💡 Motivation and Context

Reported in here: getsentry/sentry#74322 (comment)

💚 How did you test it?

Unit test

📝 Checklist

You have to check all boxes before merging:

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1233.90 ms	1245.86 ms	11.96 ms
Size	21.90 KiB	707.43 KiB	685.53 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
4bad5f9	1237.20 ms	1250.51 ms	13.31 ms
728804f	1235.26 ms	1254.20 ms	18.94 ms
861d361	1227.90 ms	1231.45 ms	3.55 ms
add8416	1270.72 ms	1300.38 ms	29.66 ms
af1f4dd	1225.39 ms	1245.48 ms	20.09 ms
ed49f0c	1245.67 ms	1261.15 ms	15.48 ms
7bc3c0d	1259.74 ms	1268.45 ms	8.71 ms
02a972c	1207.08 ms	1221.78 ms	14.70 ms
c59914b	1342.08 ms	1375.73 ms	33.65 ms
6943de0	1235.98 ms	1246.88 ms	10.90 ms

App size

Revision	Plain	With Sentry	Diff
4bad5f9	21.58 KiB	678.20 KiB	656.61 KiB
728804f	22.85 KiB	411.76 KiB	388.91 KiB
861d361	20.76 KiB	435.65 KiB	414.89 KiB
add8416	21.58 KiB	541.91 KiB	520.33 KiB
af1f4dd	22.85 KiB	414.71 KiB	391.86 KiB
ed49f0c	21.58 KiB	632.13 KiB	610.55 KiB
7bc3c0d	20.76 KiB	427.35 KiB	406.59 KiB
02a972c	22.85 KiB	413.42 KiB	390.57 KiB
c59914b	21.58 KiB	671.90 KiB	650.32 KiB
6943de0	20.76 KiB	393.33 KiB	372.57 KiB

Previous results on branch: fix/sr-qos

Startup times

Revision	Plain	With Sentry	Diff
fba4cfb	1238.88 ms	1261.98 ms	23.10 ms

App size

Revision	Plain	With Sentry	Diff
fba4cfb	21.58 KiB	707.53 KiB	685.95 KiB

[philipphofmann]

LGTM, thanks.

[philipphofmann]

Again, LGTM.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.340%. Comparing base (f273312) to head (aea5aab).
Report is 9 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #4439       +/-   ##
=============================================
+ Coverage   91.333%   91.340%   +0.006%     
=============================================
  Files          610       610               
  Lines        49927     49932        +5     
  Branches     18033     18034        +1     
=============================================
+ Hits         45600     45608        +8     
+ Misses        4235      4233        -2     
+ Partials        92        91        -1     

Files with missing lines	Coverage Δ
Sources/Sentry/SentrySessionReplayIntegration.m	85.658% <100.000%> (+0.283%)	⬆️
...tions/SessionReplay/SentrySessionReplayTests.swift	98.000% <100.000%> (+0.010%)	⬆️

... and 4 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f273312...aea5aab. Read the comment docs.