Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove deprecated macos-12 image #4450

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Oct 17, 2024

macos-12 runners will be fully unsupported by December 3rd, 2024, and are already deprecated. We have to remove them.

GH actions issue: actions/runner-images#10721

#skip-changelog

macos-12 will be fully unsupported by December 3rd, 2024, and
are already deprecated. We have to remove them.
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.316%. Comparing base (149877e) to head (18b0e8e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4450       +/-   ##
=============================================
- Coverage   91.318%   91.316%   -0.003%     
=============================================
  Files          609       610        +1     
  Lines        49855     49943       +88     
  Branches     17932     18029       +97     
=============================================
+ Hits         45527     45606       +79     
- Misses        4236      4245        +9     
  Partials        92        92               

see 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149877e...18b0e8e. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.98 ms 1254.31 ms 20.33 ms
Size 21.90 KiB 707.65 KiB 685.75 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0d32275 1229.62 ms 1246.51 ms 16.89 ms
42ef6ba 1201.67 ms 1214.35 ms 12.67 ms
888a145 1235.15 ms 1254.82 ms 19.67 ms
3bf3c92 1236.94 ms 1253.00 ms 16.06 ms
c3e8f71 1243.00 ms 1251.81 ms 8.81 ms
8cd6cfa 1229.88 ms 1251.45 ms 21.57 ms
c021422 1237.12 ms 1263.18 ms 26.06 ms
4053ee9 1243.71 ms 1257.84 ms 14.12 ms
706c41f 1234.67 ms 1245.94 ms 11.27 ms
e90aa6d 1277.38 ms 1303.18 ms 25.81 ms

App size

Revision Plain With Sentry Diff
0d32275 22.84 KiB 403.13 KiB 380.29 KiB
42ef6ba 21.58 KiB 417.86 KiB 396.28 KiB
888a145 21.58 KiB 713.54 KiB 691.95 KiB
3bf3c92 21.58 KiB 706.06 KiB 684.48 KiB
c3e8f71 21.58 KiB 573.05 KiB 551.47 KiB
8cd6cfa 21.58 KiB 571.85 KiB 550.26 KiB
c021422 20.76 KiB 435.64 KiB 414.88 KiB
4053ee9 20.76 KiB 435.22 KiB 414.46 KiB
706c41f 21.58 KiB 699.25 KiB 677.67 KiB
e90aa6d 21.58 KiB 418.82 KiB 397.24 KiB

@philipphofmann philipphofmann merged commit 324f8b0 into main Oct 18, 2024
59 of 63 checks passed
@philipphofmann philipphofmann deleted the ci/remove-macos-12 branch October 18, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants