-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Sentry screenName tracking #4646
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4646 +/- ##
=============================================
- Coverage 91.250% 91.248% -0.003%
=============================================
Files 624 624
Lines 72018 72088 +70
Branches 26148 26233 +85
=============================================
+ Hits 65717 65779 +62
- Misses 6202 6210 +8
Partials 99 99
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sources/Swift/Protocol/SentryViewControllerBreadcrumbTracking.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Dhiogo Brustolin <dhiogorb@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @m1entus.
LGTM
Sources/Swift/Protocol/SentryViewControllerBreadcrumbTracking.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Protocol/SentryViewControllerBreadcrumbTracking.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Philipp Hofmann <ph.hofmann@pm.me>
@m1entus, I'm sorry I haven't gotten to this yet. I still have some catchup to do after the Christmas holidays. I will definitely review this by the end of the week. |
@philipphofmann Cool thanks, no worries - take your time |
Co-authored-by: Philipp Hofmann <ph.hofmann@pm.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update. Almost, LGTM.
Sources/Swift/Protocol/SentryViewControllerBreadcrumbTracking.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Protocol/SentryViewControllerBreadcrumbTracking.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Philipp Hofmann <ph.hofmann@pm.me>
…swift Co-authored-by: Philipp Hofmann <ph.hofmann@pm.me>
…swift Co-authored-by: Philipp Hofmann <ph.hofmann@pm.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor Changelog entry, which won't block the PR. I need to wait for CI to be green and then we can merge this. Thanks @m1entus.
Co-authored-by: Philipp Hofmann <ph.hofmann@pm.me>
@m1entus, CI is complaining. You can ignore Benchmarking and Build / Release, but the other errors need fixing. |
@philipphofmann Could you tell me what should be fixes? I see that some tests are failing because error cloning repo - so not fully sure what should be fixed ? |
📜 Description
Added UIViewController custom screenName tracking ref: #4642
💡 Motivation and Context
I used
If viewController responds to
SentryViewControllerBreadcrumbTracking
then usescreenName
instead of[SwiftDescriptor getObjectClassName:controller]
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps