fix(feedback): bubble up feedback capture to objc layer#4659
Merged
armcknight merged 2 commits intoarmcknight/feat(feedback)/validate-envelopesfrom Dec 23, 2024
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## armcknight/feat(feedback)/validate-envelopes #4659 +/- ##
==================================================================================
- Coverage 90.594% 90.582% -0.013%
==================================================================================
Files 623 623
Lines 71226 71230 +4
Branches 25995 25972 -23
==================================================================================
- Hits 64527 64522 -5
- Misses 6601 6611 +10
+ Partials 98 97 -1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
This was referenced Dec 21, 2024
brustolin
reviewed
Dec 23, 2024
brustolin
reviewed
Dec 23, 2024
brustolin
approved these changes
Dec 23, 2024
Contributor
brustolin
left a comment
There was a problem hiding this comment.
A couple of comments but LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the last build issue in #4652; #skip-changelog; for #4272