chore: Remove hang tracker sdk v9 checks #6334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
requested review from
itaybre,
philipphofmann and
philprime
as code owners
❌ 15 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Comment on lines
-665
to
-682
| # if !SDK_V9 | ||
| /** | ||
| * AppHangTrackingV2 can differentiate between fully-blocking and non-fully blocking app hangs. | ||
| * fully-blocking app hang is when the main thread is stuck completely, and the app can't render a | ||
| * single frame. A non-fully-blocking app hang is when the app appears stuck to the user but can | ||
| still | ||
| * render a few frames. Fully-blocking app hangs are more actionable because the stacktrace shows | ||
| the | ||
| * exact blocking location on the main thread. As the main thread isn't completely blocked, | ||
| * non-fully-blocking app hangs can have a stacktrace that doesn't highlight the exact blocking | ||
| * location. | ||
| * | ||
| * You can use @c enableReportNonFullyBlockingAppHangs to ignore non-fully-blocking app hangs. | ||
| * | ||
| * @note This flag wins over enableAppHangTracking. When enabling both enableAppHangTracking and | ||
| enableAppHangTrackingV2, the SDK only enables enableAppHangTrackingV2 and disables | ||
| enableAppHangTracking. | ||
| */ |
There was a problem hiding this comment.
h: We must migrate this info to the enableAppHangTracking option. Now macOS uses V1 and iOS/tvOS V2.
There was a problem hiding this comment.
By this you mean the comment right? I can update that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls out hang tracker v2 for sdk v9
#skip-changelog
Closes #6335