Flush Logs on WillTerminate or WillResignActive App State
#6909
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| #import "SentryLogFlushIntegration.h" | ||
| #import "SentryClient+Private.h" | ||
| #import "SentryHub.h" | ||
| #import "SentryLogC.h" | ||
| #import "SentrySDK+Private.h" | ||
| #import "SentrySwift.h" | ||
|
|
||
| #if SENTRY_HAS_UIKIT | ||
|
There was a problem hiding this comment. Bug: Platform mismatch between integration and managerThe Additional Locations (1) |
||
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| @interface SentryLogFlushIntegration () <SentryAppStateListener> | ||
|
Member
There was a problem hiding this comment.
|
||
|
|
||
| @end | ||
|
|
||
| @implementation SentryLogFlushIntegration | ||
|
|
||
| - (BOOL)installWithOptions:(SentryOptions *)options | ||
| { | ||
| if (![super installWithOptions:options]) { | ||
| return NO; | ||
| } | ||
|
|
||
| [[[SentryDependencyContainer sharedInstance] appStateManager] addListener:self]; | ||
|
Member
There was a problem hiding this comment.
|
||
|
|
||
| return YES; | ||
| } | ||
|
|
||
| - (SentryIntegrationOption)integrationOptions | ||
| { | ||
| return kIntegrationOptionEnableLogs; | ||
| } | ||
|
|
||
| - (void)uninstall | ||
| { | ||
| [[[SentryDependencyContainer sharedInstance] appStateManager] removeListener:self]; | ||
| } | ||
|
|
||
| # pragma mark - SentryAppStateListener | ||
|
|
||
| - (void)appStateManagerWillResignActive | ||
| { | ||
| SentryClientInternal *client = [SentrySDKInternal.currentHub getClient]; | ||
| if (client != nil) { | ||
| [client flushLogs]; | ||
| } | ||
| } | ||
|
|
||
| - (void)appStateManagerWillTerminate | ||
| { | ||
| SentryClientInternal *client = [SentrySDKInternal.currentHub getClient]; | ||
| if (client != nil) { | ||
| [client flushLogs]; | ||
| } | ||
| } | ||
|
|
||
| @end | ||
|
|
||
| NS_ASSUME_NONNULL_END | ||
|
|
||
| #endif // SENTRY_HAS_UIKIT | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| #import "SentryBaseIntegration.h" | ||
| #import "SentryDefines.h" | ||
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| @interface SentryLogFlushIntegration : SentryBaseIntegration | ||
|
|
||
| @end | ||
|
|
||
| NS_ASSUME_NONNULL_END |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| @_implementationOnly import _SentryPrivate | ||
| import Foundation | ||
|
|
||
| @_spi(Private) @objc public protocol SentryAppStateListener: NSObjectProtocol { | ||
| @objc optional func appStateManagerWillResignActive() | ||
| @objc optional func appStateManagerWillTerminate() | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m: If the logBatcher then actually flushes the logs, shouldn't we rename the method toflush?