Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Nov 26, 2025

#skip-changelog

Closes #6912

@noahsmartin noahsmartin added the ready-to-merge Use this label to trigger all PR workflows label Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.931%. Comparing base (ca1c55d) to head (f9c8edc).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6911       +/-   ##
=============================================
+ Coverage   84.832%   84.931%   +0.099%     
=============================================
  Files          453       453               
  Lines        27611     27587       -24     
  Branches     12115     12112        -3     
=============================================
+ Hits         23423     23430        +7     
+ Misses        4142      4112       -30     
+ Partials        46        45        -1     
Files with missing lines Coverage Δ
Sources/Sentry/SentrySessionReplayIntegration.m 89.414% <ø> (+3.483%) ⬆️

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1c55d...f9c8edc. Read the comment docs.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Non-modular header import breaks hybrid SDK builds

Removing SentryIntegrationProtocol.h from the _Hybrid module map while keeping SentryBaseIntegration.h in it creates a module dependency issue. SentryBaseIntegration.h imports and conforms to SentryIntegrationProtocol, but that header is no longer part of any module (not in _Hybrid, not in the umbrella header). This can cause "include of non-modular header inside framework module" errors when hybrid SDKs use modular imports like @import Sentry._Hybrid.

Sources/Resources/Sentry.modulemap#L18-L19

header "SentryBaseIntegration.h"

Fix in Cursor Fix in Web


Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if it breaks a hybrid SDK, we can revisit. It shouldn't as pointed out here #6862 (comment)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.14 ms 1253.95 ms 36.81 ms
Size 24.14 KiB 1.01 MiB 1012.63 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b9ceffb 1222.57 ms 1247.96 ms 25.39 ms
8ad303c 1220.02 ms 1231.79 ms 11.77 ms
72a8746 1215.23 ms 1259.22 ms 43.99 ms
480185d 1220.50 ms 1246.04 ms 25.54 ms
04f41a1 1215.82 ms 1252.36 ms 36.54 ms
605fa27 1226.31 ms 1251.35 ms 25.05 ms
b13e93a 1236.24 ms 1247.33 ms 11.08 ms
67e8e3e 1238.80 ms 1266.02 ms 27.22 ms
06a9389 1245.96 ms 1276.51 ms 30.55 ms
fc6557e 1226.40 ms 1249.88 ms 23.48 ms

App size

Revision Plain With Sentry Diff
b9ceffb 23.75 KiB 969.07 KiB 945.32 KiB
8ad303c 23.75 KiB 879.24 KiB 855.49 KiB
72a8746 23.74 KiB 976.79 KiB 953.05 KiB
480185d 23.75 KiB 913.42 KiB 889.67 KiB
04f41a1 24.14 KiB 1.01 MiB 1015.39 KiB
605fa27 23.75 KiB 908.03 KiB 884.28 KiB
b13e93a 23.75 KiB 855.37 KiB 831.62 KiB
67e8e3e 23.75 KiB 919.88 KiB 896.13 KiB
06a9389 23.74 KiB 995.48 KiB 971.73 KiB
fc6557e 23.75 KiB 866.68 KiB 842.93 KiB

Previous results on branch: removeIntegrationHybridPublic

Startup times

Revision Plain With Sentry Diff
07e77e2 1211.02 ms 1244.30 ms 33.28 ms

App size

Revision Plain With Sentry Diff
07e77e2 24.14 KiB 1.01 MiB 1012.93 KiB

@noahsmartin noahsmartin force-pushed the removeIntegrationHybridPublic branch 2 times, most recently from dadfd28 to 2a225b2 Compare November 26, 2025 16:34
@noahsmartin noahsmartin force-pushed the removeIntegrationHybridPublic branch 3 times, most recently from 0d6a42d to 7614e22 Compare November 26, 2025 17:00
@noahsmartin noahsmartin force-pushed the removeIntegrationHybridPublic branch from 7614e22 to f9c8edc Compare November 26, 2025 17:07
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@noahsmartin noahsmartin merged commit fafba63 into main Nov 26, 2025
211 of 219 checks passed
@noahsmartin noahsmartin deleted the removeIntegrationHybridPublic branch November 26, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Move SentryIntegrationProtocol out of hybrid public

3 participants