Skip to content

Conversation

nikolovlazar
Copy link
Member

DESCRIBE YOUR PR

Adding some predefined matches for ignoring common spans.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@nikolovlazar nikolovlazar requested a review from sfanahata October 2, 2025 17:11
Copy link

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 2, 2025 6:53pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 2, 2025 6:53pm

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Oct 2, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.13MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.93MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/SqLTxrpVXjh0KZcmybNn8/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/SqLTxrpVXjh0KZcmybNn8/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/83XjsPkuypo0VSMduTpsP/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/83XjsPkuypo0VSMduTpsP/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

{op: /resource\.(link|script)/, name: /.+\.js.*$/},

// Images
{op: /resource\.(other|img)/, name: /.+\.(png|svg|jpe?g|gif|bmp|tiff?|webp|avif|heic?|ico).*$/},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Regex Patterns Incorrectly Match File Extensions

The ignoreSpans examples for CSS, JS, and image files use regex patterns that are too broad. The .*$ at the end allows them to incorrectly match filenames containing the extension string but not ending with it (e.g., file.css.map, script.js.backup). This could lead to unintended spans being ignored.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant