-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(js-browser): adding predefined matches for ignoring common spans #15116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
{op: /resource\.(link|script)/, name: /.+\.js.*$/}, | ||
|
||
// Images | ||
{op: /resource\.(other|img)/, name: /.+\.(png|svg|jpe?g|gif|bmp|tiff?|webp|avif|heic?|ico).*$/}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Regex Patterns Incorrectly Match File Extensions
The ignoreSpans
examples for CSS, JS, and image files use regex patterns that are too broad. The .*$
at the end allows them to incorrectly match filenames containing the extension string but not ending with it (e.g., file.css.map
, script.js.backup
). This could lead to unintended spans being ignored.
DESCRIBE YOUR PR
Adding some predefined matches for ignoring common spans.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES