Skip to content

Conversation

@giortzisg
Copy link
Contributor

Description

Change the default for ignoring 404 status codes.

Issues

@giortzisg giortzisg requested a review from lcian October 30, 2025 12:39
@linear
Copy link

linear bot commented Oct 30, 2025

@giortzisg giortzisg self-assigned this Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.90%. Comparing base (9871195) to head (7d8c3fd).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1122   +/-   ##
=======================================
  Coverage   86.89%   86.90%           
=======================================
  Files          60       61    +1     
  Lines        5555     5559    +4     
=======================================
+ Hits         4827     4831    +4     
- Misses        541      542    +1     
+ Partials      187      186    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CHANGELOG.md Outdated

## Unreleased Changes

### Breaking Cahnges
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Breaking Cahnges
### Breaking Changes

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left some comments.

@lcian
Copy link
Member

lcian commented Oct 30, 2025

Flaky test?

@giortzisg giortzisg merged commit 2d82e58 into master Nov 5, 2025
26 of 27 checks passed
@giortzisg giortzisg deleted the feat/trace-ignore-default branch November 5, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change default behavior to stop tracing 404s unless explicitly enabled

3 participants