feat(android): Add log flushing on app backgrounding #4873
+224
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add flushLogs() method to ISentryClient interface and implement it in SentryClient to allow log processors to flush any buffered logs when the app transitions to the background. This is integrated into the lifecycle watcher and can be enabled via an opt-in SentryOptions flag. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
markushi
requested review from
adinauer,
lcian,
romtsn and
stefanosiano
as code owners
Contributor
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MainActivity.java
Outdated
Show resolved
Hide resolved
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d217708 | 375.27 ms | 415.68 ms | 40.41 ms |
| fcec2f2 | 314.96 ms | 373.66 ms | 58.70 ms |
| ee747ae | 405.43 ms | 485.70 ms | 80.28 ms |
| bdbe1f4 | 380.66 ms | 464.44 ms | 83.78 ms |
| b750b96 | 421.25 ms | 444.09 ms | 22.84 ms |
| 674d437 | 355.28 ms | 504.18 ms | 148.90 ms |
| ee747ae | 415.92 ms | 470.15 ms | 54.23 ms |
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| 27d7cf8 | 306.76 ms | 366.66 ms | 59.90 ms |
| b3d8889 | 420.46 ms | 453.71 ms | 33.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| bdbe1f4 | 1.58 MiB | 2.11 MiB | 538.88 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
| 674d437 | 1.58 MiB | 2.10 MiB | 530.94 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| b3d8889 | 1.58 MiB | 2.10 MiB | 535.07 KiB |
markushi
commented
Nov 6, 2025
| */ | ||
| void flush(long timeoutMillis); | ||
|
|
||
| void flushLogs(long timeoutMillis); |
Member
Author
There was a problem hiding this comment.
Not the biggest fan of adding a new API here, an alternative would be to move this directly into ILoggerApi
Member
|
Isn't log processor flushing every 5 seconds anyway? |
Member
Author
The spec mentions this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds log flushing functionality that triggers when the Android app transitions to the background.