Skip to content

build(deps): bump getsentry/github-workflows/.github/workflows/updater.yml from 2 to 3 #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

build(deps): bump getsentry/github-workflows/.github/workflows/updater.yml from 2 to 3 #4884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/update-deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:

jobs:
native:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
Copy link

@cursor cursor bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: V3 Upgrade: Workflow Syntax Mismatch

The upgrade to v3 is incomplete. According to the breaking changes, v3 converted from reusable workflows to composite actions, requiring jobs to use runs-on and steps, change the path from .github/workflows/updater.yml to updater, and move api-token from secrets: to with:. The current syntax still uses the old reusable workflow format which no longer exists in v3, causing the workflow to fail.

Fix in Cursor Fix in Web

Copy link

@sentry sentry bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The uses syntax for getsentry/github-workflows v3 is incorrect, referencing a non-existent path for the updater composite action.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The uses statement for getsentry/github-workflows specifies the old reusable workflow path getsentry/github-workflows/.github/workflows/updater.yml@v3. However, v3 of getsentry/github-workflows migrated updater to a composite action, which requires the syntax getsentry/github-workflows/updater@v3. GitHub Actions will fail to locate the resource at the specified path, causing the workflow execution to terminate. This affects both the native and gradle-wrapper jobs.

💡 Suggested Fix

Update the uses statements from getsentry/github-workflows/.github/workflows/updater.yml@v3 to getsentry/github-workflows/updater@v3 for both native and gradle-wrapper jobs.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/update-deps.yml#L14

Potential issue: The `uses` statement for `getsentry/github-workflows` specifies the old
reusable workflow path `getsentry/github-workflows/.github/workflows/updater.yml@v3`.
However, v3 of `getsentry/github-workflows` migrated `updater` to a composite action,
which requires the syntax `getsentry/github-workflows/updater@v3`. GitHub Actions will
fail to locate the resource at the specified path, causing the workflow execution to
terminate. This affects both the `native` and `gradle-wrapper` jobs.

Did we get this right? 👍 / 👎 to inform future reviews.

with:
path: scripts/update-sentry-native-ndk.sh
name: Native SDK
Expand All @@ -20,7 +20,7 @@ jobs:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

gradle-wrapper:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
Copy link

@cursor cursor bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Workflow Syntax Obsolete After Upgrade

The upgrade to v3 is incomplete. According to the breaking changes, v3 converted from reusable workflows to composite actions, requiring jobs to use runs-on and steps, change the path from .github/workflows/updater.yml to updater, and move api-token from secrets: to with:. The current syntax still uses the old reusable workflow format which no longer exists in v3, causing the workflow to fail.

Fix in Cursor Fix in Web

Copy link

@cursor cursor bot Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SSH key passed to api-token violates v3 validation

The api-token input is assigned secrets.CI_DEPLOY_KEY, which suggests an SSH key. Version 3 adds validation that rejects SSH keys in api-token and introduces a dedicated ssh-key input. If this secret is an SSH key, it must be passed to ssh-key to prevent the workflow from failing validation; api-token is for GitHub API tokens (PAT/GITHUB_TOKEN).

Fix in Cursor Fix in Web

with:
path: scripts/update-gradle.sh
name: Gradle
Expand Down
Loading