Skip to content

Conversation

@supervacuus
Copy link
Collaborator

📜 Description

As discussed yesterday during the sync, let's establish native exception mechanisms right away.

💡 Motivation and Context

allows us to cleanly differentiate which handler an event originated from. This is particularly helpful since we now also merge events from two different mechanisms: #5037

💚 How did you test it?

adapted the affected unit tests.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 319.00 ms 370.68 ms 51.68 ms
Size 1.58 MiB 2.19 MiB 620.05 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
dba088c 333.98 ms 381.16 ms 47.18 ms
91bb874 310.68 ms 359.24 ms 48.56 ms
d15471f 315.61 ms 360.22 ms 44.61 ms
27d7cf8 314.17 ms 347.00 ms 32.83 ms
a5ab36f 316.83 ms 394.54 ms 77.71 ms
5b66efd 308.67 ms 363.85 ms 55.18 ms
abfcc92 337.38 ms 427.39 ms 90.00 ms
fc5ccaf 279.11 ms 353.34 ms 74.23 ms
fcec2f2 328.91 ms 387.75 ms 58.84 ms
dba088c 365.46 ms 366.31 ms 0.85 ms

App size

Revision Plain With Sentry Diff
dba088c 1.58 MiB 2.13 MiB 558.99 KiB
91bb874 1.58 MiB 2.13 MiB 559.07 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
a5ab36f 1.58 MiB 2.12 MiB 555.26 KiB
5b66efd 1.58 MiB 2.13 MiB 559.07 KiB
abfcc92 1.58 MiB 2.13 MiB 557.31 KiB
fc5ccaf 1.58 MiB 2.13 MiB 557.54 KiB
fcec2f2 1.58 MiB 2.12 MiB 551.50 KiB
dba088c 1.58 MiB 2.13 MiB 558.99 KiB

@github-actions
Copy link
Contributor

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • Establish native exception mechanisms by supervacuus in #5052

Internal Changes 🔧

  • (android) Update targetSdk to API 36 (Android 16) by markushi in #5016
  • (ci) Write permission for statuses in changelog preview by supervacuus in #5053

🤖 This preview updates automatically when you update the PR.

Comment on lines +7 to +9
TOMBSTONE("tombstone"),
SIGNAL_HANDLER("signalhandler"),
TOMBSTONE_MERGED("tombstone_merged");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TOMBSTONE("tombstone"),
SIGNAL_HANDLER("signalhandler"),
TOMBSTONE_MERGED("tombstone_merged");
TOMBSTONE("Tombstone"),
SIGNAL_HANDLER("signalhandler"),
TOMBSTONE_MERGED("TombstoneMerged");

I think we're really inconsistent with naming across SDKs, but we tend to use camelCase in the Java SDK, so I'm thinking if we could change that? signalhandler probably has to stay as-is to not break existing filters, but the new ones we may change to follow camelCase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants