-
-
Notifications
You must be signed in to change notification settings - Fork 465
fix: establish native exception mechanisms #5052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dba088c | 333.98 ms | 381.16 ms | 47.18 ms |
| 91bb874 | 310.68 ms | 359.24 ms | 48.56 ms |
| d15471f | 315.61 ms | 360.22 ms | 44.61 ms |
| 27d7cf8 | 314.17 ms | 347.00 ms | 32.83 ms |
| a5ab36f | 316.83 ms | 394.54 ms | 77.71 ms |
| 5b66efd | 308.67 ms | 363.85 ms | 55.18 ms |
| abfcc92 | 337.38 ms | 427.39 ms | 90.00 ms |
| fc5ccaf | 279.11 ms | 353.34 ms | 74.23 ms |
| fcec2f2 | 328.91 ms | 387.75 ms | 58.84 ms |
| dba088c | 365.46 ms | 366.31 ms | 0.85 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
| 91bb874 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| a5ab36f | 1.58 MiB | 2.12 MiB | 555.26 KiB |
| 5b66efd | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
| TOMBSTONE("tombstone"), | ||
| SIGNAL_HANDLER("signalhandler"), | ||
| TOMBSTONE_MERGED("tombstone_merged"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| TOMBSTONE("tombstone"), | |
| SIGNAL_HANDLER("signalhandler"), | |
| TOMBSTONE_MERGED("tombstone_merged"); | |
| TOMBSTONE("Tombstone"), | |
| SIGNAL_HANDLER("signalhandler"), | |
| TOMBSTONE_MERGED("TombstoneMerged"); |
I think we're really inconsistent with naming across SDKs, but we tend to use camelCase in the Java SDK, so I'm thinking if we could change that? signalhandler probably has to stay as-is to not break existing filters, but the new ones we may change to follow camelCase
📜 Description
As discussed yesterday during the sync, let's establish native exception mechanisms right away.
💡 Motivation and Context
allows us to cleanly differentiate which handler an event originated from. This is particularly helpful since we now also merge events from two different mechanisms: #5037
💚 How did you test it?
adapted the affected unit tests.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps