-
Notifications
You must be signed in to change notification settings - Fork 561
fix(openai-agents): also emit spans for MCP tool calls done by the LLM #4875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(openai-agents): also emit spans for MCP tool calls done by the LLM #4875
Conversation
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the cursor comment -- might have a point.
Looks good to me otherwise, but please also add a test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise looks good, thanks for adding the tests!
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
Description
We cannot directly intercept MCP Tool calls, as they are done remotely by the LLM and not in the Agent itself. However, we see when such a tool call took place, so we can emit a zero-length span with the tool call specifics. It will start at the same time as the parent span.
Closes https://linear.app/getsentry/issue/TET-1192/openai-agents-hosted-mcp-calls-cannot-be-wrapped-in-an-execute-tool
Note
Emit execute_tool spans for MCP tool calls detected in agent results, with tool metadata, input/output (PII-gated), and error status.
utils._create_mcp_execute_tool_spans
to emitOP.GEN_AI_EXECUTE_TOOL
spans for MCP tool calls (McpCall
) found inresult.output
.GEN_AI_TOOL_TYPE=mcp
,GEN_AI_TOOL_NAME
, propagates input/output when PII allowed, and marksSPANSTATUS.ERROR
on error.spans/ai_client.update_ai_client_span
to create these tool spans after setting usage/input/output data.SPANSTATUS
andOP
.Written by Cursor Bugbot for commit 96df8c1. This will update automatically on new commits. Configure here.