-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt rubocop and format the project #2241
Conversation
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Ruby | ||
uses: ruby/setup-ruby@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2241 +/- ##
==========================================
+ Coverage 97.41% 97.43% +0.02%
==========================================
Files 102 102
Lines 3823 3823
==========================================
+ Hits 3724 3725 +1
+ Misses 99 98 -1
|
rubocop-rails-omakase: rubocop.yml | ||
|
||
Layout/SpaceInsideArrayLiteralBrackets: | ||
Enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to not liking this style myself, having it enabled requires changing almost all array literals in the codebase (~500 more offences). So I decided to not take this one in.
@sl0thentr0py 👋 let me know if you have concern about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thx!
In addition to having a consistent coding style through CI checks, anyone uses a LSP server (whether
Ruby LSP
orSolargraph
) will have auto-formatting in their editor as well.standard
as it's not supported byRuby LSP
atmrubocop -a
on the entire project to apply the styles, with a couple of manual adjustments.#skip-changelog