Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sidekiq 8.0 beta to CI metrix #2555

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Add Sidekiq 8.0 beta to CI metrix #2555

merged 1 commit into from
Feb 8, 2025

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Feb 8, 2025

I was expecting to see some broken tests and fix them in this PR. But it's great to see our SDK may be 100% compatible with the next major Sidekiq version too :-)

#skip-changelog

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.70%. Comparing base (a22e595) to head (39d5df4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2555   +/-   ##
=======================================
  Coverage   69.70%   69.70%           
=======================================
  Files         126      126           
  Lines        4737     4737           
=======================================
  Hits         3302     3302           
  Misses       1435     1435           
Components Coverage Δ
sentry-ruby 60.63% <ø> (ø)
sentry-rails 97.48% <ø> (ø)
sentry-sidekiq 95.52% <ø> (ø)
sentry-resque 92.64% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)

@st0012 st0012 marked this pull request as ready for review February 8, 2025 16:17
@st0012 st0012 force-pushed the add-sidekiq-8-to-ci branch from c54089c to 3a142c9 Compare February 8, 2025 16:42
@st0012 st0012 force-pushed the add-sidekiq-8-to-ci branch from 3a142c9 to 39d5df4 Compare February 8, 2025 16:46
@st0012 st0012 requested review from solnic and sl0thentr0py February 8, 2025 17:27
@st0012 st0012 merged commit 6fba436 into master Feb 8, 2025
141 checks passed
@st0012 st0012 deleted the add-sidekiq-8-to-ci branch February 8, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants