Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better CI setup #2563

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Better CI setup #2563

merged 3 commits into from
Feb 19, 2025

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Feb 18, 2025

This adds a new top-level workflow called "Tests & CodeCov" that orchestrates running tests for all 6 gems and once they are done, it runs CodeCov.

This has multiple advantages:

  • We run ruby-versions workflow just once and pass it to the test workflows
  • We can observe all tests running from a single workflow UI
  • We run codecov after all coverage reports were submitted
  • It looks cool 👇🏻
Screenshot 2025-02-19 at 14 28 32

#skip-changelog

@getsentry getsentry deleted a comment from github-actions bot Feb 19, 2025
@solnic solnic force-pushed the solnic/fix-codecov-wf branch 2 times, most recently from 503b35f to 70e5aec Compare February 19, 2025 13:01
@getsentry getsentry deleted a comment from github-actions bot Feb 19, 2025
@getsentry getsentry deleted a comment from github-actions bot Feb 19, 2025
@getsentry getsentry deleted a comment from github-actions bot Feb 19, 2025
@solnic solnic force-pushed the solnic/fix-codecov-wf branch from e67116c to 7e5c63f Compare February 19, 2025 13:30
@solnic solnic changed the title Fix codecov wf Better CI setup Feb 19, 2025
@getsentry getsentry deleted a comment from github-actions bot Feb 19, 2025
@solnic
Copy link
Collaborator Author

solnic commented Feb 19, 2025

@sl0thentr0py final touch is to set up codecov token because:

==> Running send-notifications
      ./codecov send-notifications --sha 2c8238d6d9b9e52e9bcfb8b19de5932f680555d4 --git-service github
info - 2025-02-19 13:42:16,580 -- ci service found: github-actions
info - 2025-02-19 13:42:16,989 -- Process Upload Completion complete
error - 2025-02-19 13:42:16,990 -- Upload Completion failed: {"message":"Token required because branch is protected"}

@sl0thentr0py
Copy link
Member

the secret CODECOV_TOKEN is available to all sentry repos orgwide

          token: ${{ secrets.CODECOV_TOKEN }}

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty, ty!

@solnic solnic merged commit 2a28c01 into master Feb 19, 2025
155 checks passed
@solnic solnic deleted the solnic/fix-codecov-wf branch February 19, 2025 14:23
@st0012
Copy link
Collaborator

st0012 commented Feb 22, 2025

This is the most advanced GH Actions usage I've seen in Ruby projects 🤯 Very impressive improvement 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants