feat: include otel as custom sampling contex #2683
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
solnic
reviewed
Sep 3, 2025
solnic
requested changes
Sep 3, 2025
sentry-opentelemetry/spec/sentry/opentelemetry/span_processor_spec.rb
Outdated
Show resolved
Hide resolved
Sentry's opentelemetry adapter does not do the greatest job in adapting the opentelemetry span to a semantically correct sentry span, nor does it expose the opentelemetry span in the context for sampling decisions. This PR adds a opentelemetry span as an additional custom sampling context so it can be used for sampling decisions. This gives clients more opportunity to use the entire context of the opentelemetry span for sampling decisions, and allows replicating sampling mechanisms as orignally suggested by the Sentry team via the "Sampling Function". https://docs.sentry.io/platforms/ruby/configuration/sampling/#setting-a-sampling-function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry's OpenTelemetry (OTel) adapter does not do the greatest job in adapting the OTel span to a semantically correct sentry span, nor does it expose the OTel span in the context for sampling decisions. This PR adds a OTel span as an additional custom sampling context so it can be used for sampling decisions. This gives clients more opportunities to use the entire context of the OTel span for sampling decisions, and allows replicating sampling mechanisms as originally suggested by the Sentry team via the "Sampling Function".
https://docs.sentry.io/platforms/ruby/configuration/sampling/#setting-a-sampling-function
Thanks for your Pull Request 🎉
Please keep these instructions in mind so we can review it more efficiently:
Other Notes
closes #2684
closes RUBY-86