-
-
Notifications
You must be signed in to change notification settings - Fork 176
build(deps): update reqwest from v0.12.25 to v0.13.1
#958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: szokeasaurusrex/update-cargo
Are you sure you want to change the base?
build(deps): update reqwest from v0.12.25 to v0.13.1
#958
Conversation
This fixes a failing doctest.
Run `cargo update` to bump all dependencies to the latest versions.
…pdate # Conflicts: # CHANGELOG.md # Cargo.lock
This dependency bump is a breaking change. https://docs.rs/sentry/latest/sentry/transports/struct.ReqwestHttpTransport.html#method.with_client
0cb5f31 to
fb9917f
Compare
…pdate # Conflicts: # Cargo.lock
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thank you @AlexTMjugador 🙏
@Dav1dde can you also take a look? I have based this on top of my cargo update in #968, it does not seem like we are duplicating very many dependencies in the Cargo.lock with that change.
Dav1dde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks good 🙏
Description
This PR updates
reqwestfrom v0.12.25 to v0.13.1. From a user perspective, the most noteworthy change is that it switches the defaultrustlsprovider fromringtoaws-lc-rs. This bringsreqwestin line with the broader ecosystem's move towardaws-lc-rsas the default and increases the likelihood that users will no longer need to include multiple TLS implementations in their binaries.Stacked on #968
Issues
This resolves a personal goal of mine, as a user, to remove
ringfrom my transitive dependency tree. However, it does not address an issue that was previously documented in this repository.