Skip to content

ci: Replace make targets and remove Makefile #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szokeasaurusrex merged 1 commit into from
Feb 12, 2026
Merged

ci: Replace make targets and remove Makefile #987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 52 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,45 @@ jobs:

- uses: Swatinem/rust-cache@v2

- run: make checkall
- name: Check all features
run: cargo check --all-features
env:
RUSTFLAGS: -Dwarnings

- name: Check sentry-core without default features
run: cargo check --no-default-features
working-directory: sentry-core
env:
RUSTFLAGS: -Dwarnings

- name: Check default features
run: cargo check
env:
RUSTFLAGS: -Dwarnings

- name: Check sentry panic feature without defaults
run: cargo check --no-default-features --features panic
working-directory: sentry
env:
RUSTFLAGS: -Dwarnings

- name: Check sentry curl feature
run: cargo check --features curl
working-directory: sentry
env:
RUSTFLAGS: -Dwarnings

- name: Check sentry curl+panic without defaults
run: cargo check --no-default-features --features curl,panic
working-directory: sentry
env:
RUSTFLAGS: -Dwarnings

- name: Check sentry-actix
run: cargo check
working-directory: sentry-actix
env:
RUSTFLAGS: -Dwarnings
Copy link
Member

@lcian lcian Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably expand this by checking each of the subcrates individually, I think we just forgot to add them to the makefile as new crates were created

Copy link
Member Author

@szokeasaurusrex szokeasaurusrex Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any benefit to checking the sub crates individually? Shouldn't we just run check at the workspace level?

Copy link
Member

@lcian lcian Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but you would also need to make sure you're selecting the features that enable a particular subcrate.
e.g. instead of cargo check in sentry-actix working directory you would cargo check sentry with the actix feature, etc.

Copy link
Member Author

@szokeasaurusrex szokeasaurusrex Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got it. Let's do this in a later PR; for now I am trying to keep a narrow scope on the CI improvement effort


test:
strategy:
Expand Down Expand Up @@ -81,9 +119,20 @@ jobs:

- uses: Swatinem/rust-cache@v2

- run: make checkfast
- name: Check sentry-core without default features
run: cargo check --no-default-features
working-directory: sentry-core
env:
RUSTFLAGS: -Dwarnings

- run: make testfast
- name: Check default features
run: cargo check
env:
RUSTFLAGS: -Dwarnings

- name: Test sentry test feature
run: cargo test --features=test
working-directory: sentry

codecov:
name: Code Coverage
Expand Down
94 changes: 0 additions & 94 deletions Makefile
View file
Open in desktop

This file was deleted.