Skip to content

Commit

Permalink
fix(rr6): Do not call useRouteContext outside of shim hooks (#78217)
Browse files Browse the repository at this point in the history
Fixes #78202
Fixes [JAVASCRIPT-2VNE](https://sentry.sentry.io/issues/5793472257/)

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
  • Loading branch information
evanpurkhiser and getsantry[bot] authored Sep 26, 2024
1 parent 729a0e9 commit 39133fb
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions static/app/views/dataExport/dataDownload.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {space} from 'sentry/styles/space';
import type {RouteComponentProps} from 'sentry/types/legacyReactRouter';
import {useApiQuery} from 'sentry/utils/queryClient';
import normalizeUrl from 'sentry/utils/url/normalizeUrl';
import {useRouteContext} from 'sentry/utils/useRouteContext';
import {useNavigate} from 'sentry/utils/useNavigate';
import Layout from 'sentry/views/auth/layout';

export enum DownloadStatus {
Expand Down Expand Up @@ -56,7 +56,7 @@ function DataDownload({params: {orgId, dataExportId}}: Props) {
staleTime: 0,
});

const route = useRouteContext();
const navigate = useNavigate();

if (isError) {
const errDetail = error?.responseJSON?.detail;
Expand Down Expand Up @@ -155,7 +155,6 @@ function DataDownload({params: {orgId, dataExportId}}: Props) {
};

const openInDiscover = () => {
const navigator = route.router;
const {
query: {info},
} = download;
Expand All @@ -165,7 +164,7 @@ function DataDownload({params: {orgId, dataExportId}}: Props) {
query: info,
};

navigator.push(normalizeUrl(to));
navigate(normalizeUrl(to));
};

const renderOpenInDiscover = () => {
Expand Down

0 comments on commit 39133fb

Please sign in to comment.