Skip to content

Commit

Permalink
add test
Browse files Browse the repository at this point in the history
  • Loading branch information
lobsterkatie committed Aug 28, 2024
1 parent b015aef commit 47426f0
Showing 1 changed file with 38 additions and 0 deletions.
38 changes: 38 additions & 0 deletions tests/sentry/event_manager/test_event_manager_grouping.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,13 @@
from sentry.grouping.result import CalculatedHashes
from sentry.models.auditlogentry import AuditLogEntry
from sentry.models.group import Group
from sentry.models.grouphash import GroupHash
from sentry.models.grouphashmetadata import GroupHashMetadata
from sentry.projectoptions.defaults import DEFAULT_GROUPING_CONFIG
from sentry.testutils.cases import TestCase
from sentry.testutils.helpers import Feature
from sentry.testutils.helpers.eventprocessing import save_new_event
from sentry.testutils.helpers.options import override_options
from sentry.testutils.pytest.fixtures import django_db_all
from sentry.testutils.silo import assume_test_silo_mode_of
from sentry.testutils.skips import requires_snuba
Expand Down Expand Up @@ -165,6 +169,40 @@ def test_auto_updates_grouping_config(self):
)
assert actual_expiry == expected_expiry or actual_expiry == expected_expiry - 1

def test_creates_grouphash_metadata_when_appropriate(self):

# The killswitch is obeyed
with override_options({"grouping.grouphash_metadata.ingestion_writes_enabled": False}):
event1 = save_new_event({"message": "Dogs are great!"}, self.project)
grouphash = GroupHash.objects.filter(
project=self.project, hash=event1.get_primary_hash()
).first()
assert grouphash and grouphash.metadata is None

# The feature flag is obeyed
with Feature({"organizations:grouphash-metadata-creation": False}):
event2 = save_new_event({"message": "Sit! Good dog!"}, self.project)
grouphash = GroupHash.objects.filter(
project=self.project, hash=event2.get_primary_hash()
).first()
assert grouphash and grouphash.metadata is None

with Feature({"organizations:grouphash-metadata-creation": True}):
# New hashes get metadata
event3 = save_new_event({"message": "Adopt, don't shop"}, self.project)
grouphash = GroupHash.objects.filter(
project=self.project, hash=event3.get_primary_hash()
).first()
assert grouphash and isinstance(grouphash.metadata, GroupHashMetadata)

# For now, existing hashes aren't backfiled when new events are assigned to them
event4 = save_new_event({"message": "Dogs are great!"}, self.project)
assert event4.get_primary_hash() == event1.get_primary_hash()
grouphash = GroupHash.objects.filter(
project=self.project, hash=event4.get_primary_hash()
).first()
assert grouphash and grouphash.metadata is None


class PlaceholderTitleTest(TestCase):
"""
Expand Down

0 comments on commit 47426f0

Please sign in to comment.