Skip to content

Commit

Permalink
fix(issue-views): Make tab bar take up entire row (#79383)
Browse files Browse the repository at this point in the history
Fixes an issue where the tab bar did not take up the entire row in the
header's grid container. This led to the overflow menu triggering too
eagerly.

Before:

<img width="894" alt="image"
src="https://github.com/user-attachments/assets/363fc666-2de2-417f-a53a-d0011cfdcd41">


After:

<img width="909" alt="image"
src="https://github.com/user-attachments/assets/104a7137-d9aa-4af7-80fd-86e59a7b7d71">
  • Loading branch information
MichaelSun48 authored Oct 18, 2024
1 parent 283f68e commit 48a8010
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions static/app/views/issueList/customViewsHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,9 @@ function CustomViewsIssueListHeader({
</Layout.HeaderActions>
<StyledGlobalEventProcessingAlert projects={selectedProjects} />
{groupSearchViews ? (
<Tabs>
<StyledTabs>
<CustomViewsIssueListHeaderTabsContent {...props} views={groupSearchViews} />
</Tabs>
</StyledTabs>
) : (
<div style={{height: 33}} />
)}
Expand Down Expand Up @@ -475,6 +475,10 @@ function CustomViewsIssueListHeaderTabsContent({

export default CustomViewsIssueListHeader;

const StyledTabs = styled(Tabs)`
grid-column: 1 / -1;
`;

const StyledGlobalEventProcessingAlert = styled(GlobalEventProcessingAlert)`
grid-column: 1/-1;
margin-top: ${space(1)};
Expand Down

0 comments on commit 48a8010

Please sign in to comment.