fix(authenticator): Display loading error if authenticator is null

getsentry · Aug 28, 2024 · 4d9ba3d · 4d9ba3d
1 parent c034581
commit 4d9ba3d
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/static/app/views/settings/account/accountSecurity/accountSecurityDetails.tsx b/static/app/views/settings/account/accountSecurity/accountSecurityDetails.tsx
@@ -119,7 +119,7 @@ function AccountSecurityDetails({deleteDisabled, onRegenerateBackupCodes}: Props
   );
 
   const handleRemove = (device?: AuthenticatorDevice) => {
-    if (!authenticator || !authenticator.authId) {
+    if (!authenticator?.authId) {
       return;
     }
     remove({id: authenticator.authId, device});
@@ -136,14 +136,10 @@ function AccountSecurityDetails({deleteDisabled, onRegenerateBackupCodes}: Props
     return <LoadingIndicator />;
   }
 
-  if (isError) {
+  if (!authenticator || isError) {
     return <LoadingError onRetry={refetch} />;
   }
 
-  if (!authenticator) {
-    return null;
-  }
-
   return (
     <SentryDocumentTitle title={PAGE_TITLE}>
       <SettingsPageHeader