Skip to content

Commit

Permalink
bug fix
Browse files Browse the repository at this point in the history
  • Loading branch information
mifu67 committed Aug 27, 2024
1 parent faeb0ee commit 55a517f
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/sentry/incidents/serializers/alert_rule_trigger.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from django import forms
from rest_framework import serializers

from sentry.api.serializers.rest_framework.base import CamelSnakeModelSerializer
Expand Down Expand Up @@ -45,6 +46,9 @@ def create(self, validated_data):
self._handle_actions(alert_rule_trigger, actions)

return alert_rule_trigger
except forms.ValidationError as e:
# if we fail in create_alert_rule_trigger, then only one message is ever returned
raise serializers.ValidationError(e.error_list[0].message)
except AlertRuleTriggerLabelAlreadyUsedError:
raise serializers.ValidationError("This label is already in use for this alert rule")

Expand All @@ -56,6 +60,9 @@ def update(self, instance, validated_data):
alert_rule_trigger = update_alert_rule_trigger(instance, **validated_data)
self._handle_actions(alert_rule_trigger, actions)
return alert_rule_trigger
except forms.ValidationError as e:
# if we fail in update_alert_rule_trigger, then only one message is ever returned
raise serializers.ValidationError(e.error_list[0].message)
except AlertRuleTriggerLabelAlreadyUsedError:
raise serializers.ValidationError("This label is already in use for this alert rule")

Expand Down

0 comments on commit 55a517f

Please sign in to comment.