Skip to content

Commit

Permalink
✅ fix test and comment
Browse files Browse the repository at this point in the history
  • Loading branch information
michellewzhang committed Oct 18, 2024
1 parent 32ea8eb commit 5ffd0e4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions src/sentry/flags/providers.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ class LaunchDarklyItemSerializer(serializers.Serializer):
LaunchDarkly has a lot more flag actions than what's in our
ACTION_MAP. The "updated" action is the catch-all for actions
that don't fit in the other buckets.
We started out with a few actions that we think would be useful
to accept. All other actions will not be logged
to the audit log. This set of actions is subject to change.
"""


Expand Down
2 changes: 1 addition & 1 deletion tests/sentry/flags/endpoints/test_hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def test_launchdarkly_post_create(self):
response = self.client.post(self.url, request_data)

assert response.status_code == 200
assert FlagAuditLogModel.objects.count() == 1
assert FlagAuditLogModel.objects.count() == 2
flag = FlagAuditLogModel.objects.first()
assert flag is not None
assert flag.action == ACTION_MAP["created"]
Expand Down

0 comments on commit 5ffd0e4

Please sign in to comment.