fix feature flag

getsentry · Oct 18, 2024 · d4c1068 · d4c1068
1 parent c1d9149
commit d4c1068
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/sentry/api/endpoints/organization_dashboard_details.py b/src/sentry/api/endpoints/organization_dashboard_details.py
@@ -44,7 +44,9 @@ class DashboardPermissions(BasePermission):
     }
 
     def has_object_permission(self, request: Request, view, obj):
-        if isinstance(obj, Dashboard):
+        if features.has(
+            "organizations:dashboards-edit-access", obj.organization, actor=request.user
+        ) and isinstance(obj, Dashboard):
             # Check if user has permissions to edit dashboard
             if hasattr(obj, "permissions"):
                 return obj.permissions.has_edit_permissions(request.user.id)
@@ -53,10 +55,7 @@ def has_object_permission(self, request: Request, view, obj):
 
 class OrganizationDashboardBase(OrganizationEndpoint):
     owner = ApiOwner.PERFORMANCE
-    if features.has("organizations:dashboards-edit-access"):
-        permission_classes = (OrganizationDashboardsPermission, DashboardPermissions)
-    else:
-        permission_classes = (OrganizationDashboardsPermission,)
+    permission_classes = (OrganizationDashboardsPermission, DashboardPermissions)
 
     def convert_args(
         self, request: Request, organization_id_or_slug, dashboard_id, *args, **kwargs