feat(grouping): Store metadata for new grouphashes #76245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #76245 +/- ##
=======================================
Coverage 78.20% 78.20%
=======================================
Files 6895 6895
Lines 306372 306384 +12
Branches 50227 50229 +2
=======================================
+ Hits 239608 239621 +13
+ Misses 60358 60355 -3
- Partials 6406 6408 +2 |
lobsterkatie
force-pushed
the
kmclb-fix-grouphashmetadata-grouphash-property
branch
2 times, most recently
from
c292ef5
to
448c15d
Compare
Base automatically changed from
kmclb-fix-grouphashmetadata-grouphash-property
to
master
August 16, 2024 16:39
lobsterkatie
force-pushed
the
kmclb-store-metadata-for-new-grouphashes
branch
from
806dcbe
to
6f7b8f8
Compare
lobsterkatie
force-pushed
the
kmclb-store-metadata-for-new-grouphashes
branch
from
6f7b8f8
to
0b44df4
Compare
lobsterkatie
force-pushed
the
kmclb-store-metadata-for-new-grouphashes
branch
from
0b44df4
to
a546e1e
Compare
lobsterkatie
changed the base branch from
master
to
kmclb-fix-grouphash-deletion-via-project-deletion
jangjodi
reviewed
Aug 27, 2024
lobsterkatie
force-pushed
the
kmclb-fix-grouphash-deletion-via-project-deletion
branch
from
5e5026a
to
810370e
Compare
lobsterkatie
force-pushed
the
kmclb-store-metadata-for-new-grouphashes
branch
from
a546e1e
to
e12caf6
Compare
JoshFerge
reviewed
Aug 28, 2024
lobsterkatie
force-pushed
the
kmclb-fix-grouphash-deletion-via-project-deletion
branch
from
810370e
to
a3bc7a6
Compare
lobsterkatie
force-pushed
the
kmclb-store-metadata-for-new-grouphashes
branch
from
e12caf6
to
47426f0
Compare
Yup - you beat me by about two minutes. 🙂 Just pushed it again, including a feature flag. UPDATE: Here's the PR with the actual config: https://github.com/getsentry/sentry-options-automator/pull/2189. |
JoshFerge
approved these changes
Aug 29, 2024
lobsterkatie
added a commit
that referenced
this pull request
Sep 3, 2024
…76572) This is a follow-up to #76312, fixing another bug with grouphash deletion. Currently, when a project is deleted, its associated `GroupHash` records are deleted directly by the project deletion task, using the `BulkModelDeletionTask`. Unfortunately, that task doesn't take into account any dependent tables, meaning that the corresponding `GroupHashMetadata` records aren't deleted as they should be. This fixes that by allowing `GroupHash` deletions to cascade from group deletions (which themselves are set off by project deletion), rather than having the project deletion task delete the grouphashes directly. (Group deletions already handle `GroupHash`/`GroupHashMetadata` deletion correctly, using the `GroupHash`-specific deletion task registered in the deletion module's `__init__.py`[1].) Note that while the results of this change aren't tested in this PR, they are implicitly tested in #76245, which will directly follow this one and which for the first time will actually create `GroupHashMetadata` records. Without the change in this PR, the presence of that PR's new `GroupHashMetadata` records causes the project deletion test to fail, but with this change, they pass. [1] https://github.com/getsentry/sentry/blob/9155480cddb7454bba99ae39ea4caac91261ca26/src/sentry/deletions/__init__.py#L127
Base automatically changed from
kmclb-fix-grouphash-deletion-via-project-deletion
to
master
September 3, 2024 18:45
lobsterkatie
force-pushed
the
kmclb-store-metadata-for-new-grouphashes
branch
from
47426f0
to
e85e583
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the rollout of the new grouphash metadata table, this creates a
GroupHashMetadatarow for every newGroupHashwe create. It's gated by a killswitch and a feature flag, and doesn't do much yet - the only data in the table so far is a creation timestamp - but this should give us a sense of whether or not there's going to be any hit to ingest DB performance.