Skip to content

fix(preprod): truncate max status check length #102987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 10, 2025
Merged

fix(preprod): truncate max status check length #102987

merged 13 commits into from
Nov 10, 2025
+132 −5

Conversation

@trevor-e
Copy link
Member

@trevor-e trevor-e commented Nov 7, 2025

Resolves EME-612

@linear
Copy link

linear bot commented Nov 7, 2025

EME-612 Truncate the `text` and `summary` Github fields

@trevor-e trevor-e changed the base branch from master to telkins/status-check-permissions November 7, 2025 21:00
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 7, 2025
cursor[bot]
cursor bot reviewed Nov 7, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Nov 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/preprod/vcs/status_checks/size/tasks.py 46.42% 15 Missing ⚠️
Additional details and impacted files 
@@                          Coverage Diff                          @@
##           telkins/status-check-permissions   #102987      +/-   ##
=====================================================================
+ Coverage                             73.83%    80.64%   +6.81%     
=====================================================================
  Files                                  9136      9140       +4     
  Lines                                392718    393012     +294     
  Branches                              24968     24968              
=====================================================================
+ Hits                                 289944    316951   +27007     
+ Misses                               102373     75660   -26713     
  Partials                                401       401

cursor[bot]
cursor bot reviewed Nov 7, 2025
View reviewed changes
rbro112
rbro112 reviewed Nov 10, 2025
View reviewed changes
src/sentry/preprod/vcs/status_checks/size/tasks.py
raise


GITHUB_MAX_SUMMARY_FIELD_LENGTH = 65535
Copy link
Member

@rbro112 rbro112 Nov 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where'd you find references to these limits? Would rec commenting the links to their docs if there is one.

Copy link
Member Author

@trevor-e trevor-e Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, added

Base automatically changed from telkins/status-check-permissions to master November 10, 2025 18:12
@trevor-e trevor-e marked this pull request as ready for review November 10, 2025 18:40
@trevor-e trevor-e requested a review from a team as a code owner November 10, 2025 18:40
@trevor-e trevor-e merged commit 24846e0 into master Nov 10, 2025
65 checks passed
@trevor-e trevor-e deleted the telkins/status-check-truncate branch November 10, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@rbro112 rbro112 rbro112 approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trevor-e @rbro112