Skip to content

chore: Remove empty /manage/ admin overview #102988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
+1 −18
Merged

chore: Remove empty /manage/ admin overview #102988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/router/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2661,7 +2661,7 @@ function buildRoutes(): RouteObject[] {
const adminManageChildren: SentryRouteObject[] = [
{
index: true,
component: make(() => import('sentry/views/admin/adminOverview')),
component: make(() => import('sentry/views/admin/adminEnvironment')),
Copy link
Contributor

@cursor cursor bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Routing Redundancy Impairs Navigation Consistency.

The index route at /manage/ now renders adminEnvironment, but there's also an explicit route at /manage/status/environment/ that renders the same component. This creates duplicate routes for the same content and causes navigation inconsistency—when viewing /manage/, the "Environment" navigation item won't highlight as active since it expects /manage/status/environment/.

Fix in Cursor Fix in Web

Copy link
Member

@evanpurkhiser evanpurkhiser Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we fix this?

},
{
path: 'relays/',
Expand Down
1 change: 0 additions & 1 deletion static/app/views/admin/adminLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export function AdminNavigation() {
id: 'admin-system-status',
name: 'System Status',
items: [
{path: '/manage/', index: true, title: 'Overview'},
{path: '/manage/status/environment/', title: 'Environment'},
{path: '/manage/status/packages/', title: 'Packages'},
{path: '/manage/status/mail/', title: 'Mail'},
Expand Down
16 changes: 0 additions & 16 deletions static/app/views/admin/adminOverview/index.tsx
View file
Open in desktop

This file was deleted.

Loading